Review main Merged

55216[BUGFIX] Add class name to property deprecations

Benni Mack CR +2 V +2 Easy +17 −17 updated 01/04/18, 13:33

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Reiner Teubner +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1619

  1. Benni Mack uploaded patch set 1 12/27/17, 12:07

  2. Frans Saris voted on patch set 1 CR +1 12/27/17, 12:13

  3. TYPO3com voted on patch set 1 V +1 12/27/17, 12:18 Completed build in 10m 57s on Wed, 27 Dec, 01:18 PM Test Summary: 29987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17970

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 12/27/17, 12:28

  5. Andreas Kienast commented on patch set 1 CR -1 12/28/17, 07:48

    It's a soft -1. I think we should use `static::class` instead. If a class uses that trait, and someone extends the class and uses deprecated properties in there (been there, done that) the deprecation message might be misleading as the "original" class is mentioned. Is this correct?
  6. Andreas Kienast uploaded patch set 2 01/03/18, 20:43

  7. TYPO3com voted on patch set 2 V +1 01/03/18, 20:53 Completed build in 09m 30s on Wed, 3 Jan, 09:53 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18048

  8. Mathias Brodala commented on patch set 2 01/04/18, 08:59

    PublicPropertyDeprecationTrait.php:85

    I'd recommend statically adding the class name to the deprecation message instead here to not make any assumptions about the deprecation message.
  9. Christian Kuhn commented on patch set 2 CR -1 01/04/18, 11:49

    PublicPropertyDeprecationTrait.php:85 Reply

    i don't see much benefit dynamically adding the class name to the deprecation method, either. we could just very well add it to the message directly. i'll update the patch accordingly.
  10. Christian Kuhn uploaded patch set 3 01/04/18, 11:54

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 01/04/18, 11:55

  12. TYPO3com voted on patch set 3 V +1 01/04/18, 12:02 Completed build in 07m 59s on Thu, 4 Jan, 01:02 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18079

  13. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/04/18, 12:16

  14. Mathias Brodala commented on patch set 3 01/04/18, 12:19

    Maybe we can let the trait automatically build half of the message: "Public access to property %s of class %s is deprecated: %s" The last placeholder would be the description from $deprecatedPublicProperties. This would also ensure that we have a mostly consistent naming scheme in logs.
  15. Reiner Teubner voted on patch set 3 V +1 CR +1 01/04/18, 12:34

  16. Christian Kuhn voted on patch set 3 V +2 CR +2 01/04/18, 12:45

  17. Christian Kuhn merged patch set 4 01/04/18, 12:45

  18. Christian Kuhn commented on patch set 4 01/04/18, 12:47

    I think this simple change is fine for now, Matthias.
  19. Mathias Brodala commented on patch set 4 01/04/18, 13:33

    > I think this simple change is fine for now, Matthias. My suggestion can be done in a separate change, so I'm fine.