Review TYPO3_8-7 Merged

55219[BUGFIX] Add missing htmlspecialchars() and cleanup in EXT:recordlist

Stefan Neufeind CR +2 V +2 Easy +20 −9 updated 01/28/18, 13:54

Commit message

Add missing htmlspecialchars() calls in EXT:recordlist and do cleanup.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Alexander Opitz +1
    • Stephan Großberndt +1
  • Verified V +2
    • Stefan Neufeind +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1215

  1. Stefan Neufeind uploaded patch set 1 12/28/17, 03:08

  2. Stefan Neufeind commented on patch set 1 12/28/17, 03:10

    Does not fully match code from master :-( I'm unsure about one $label in AbstractLinkBrowserController.php if we need to htmlspecialchars() that there additionally or if at another label in that file the escaping is too much. @Stephan: Could you have a look at those changes please?
  3. TYPO3com voted on patch set 1 V +1 12/28/17, 03:17 Completed build in 09m 37s on Thu, 28 Dec, 04:17 AM Test Summary: 57829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1585

  4. Stephan Großberndt uploaded patch set 2 01/05/18, 09:50

  5. Stephan Großberndt commented on patch set 2 CR +1 01/05/18, 09:54

    DocumentTemplate.php:1186

    TYPO3 8.7 still has the public method getTabMenuRaw() which is deprecated and removed in 9.0 - so escaping the label has to happen here instead of AbstractLinkBrowserController->mainAction()

    AbstractDatabaseRecordList.php:1093

    This part is used from AbstractDatabaseRecordList in TYPO3 8.7
  6. TYPO3com voted on patch set 2 V +1 01/05/18, 09:58 Completed build in 08m 08s on Fri, 5 Jan, 10:58 AM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1615

  7. Stephan Großberndt uploaded patch set 3 01/05/18, 10:09

  8. Stefan Neufeind commented on patch set 3 CR +1 01/05/18, 10:12

    thanks for taking care
  9. Stephan Großberndt commented on patch set 3 CR +1 01/05/18, 10:12

    AbstractLinkBrowserController.php:177

    On second thought: Its better to backport this from master to 8.7 as the label is htmlspecialchar'd in DocumentTemplate->getTabMenu but not in AbstractLinkBrowserController->buildMenuArray so AbstractLinkBrowserController gets its labels htmlspecialchar'd here and DocumentTemplate->getTabMenuRaw remains untouched (and without double htmlspecialchar)
  10. TYPO3com voted on patch set 3 V +1 01/05/18, 10:17 Completed build in 08m 35s on Fri, 5 Jan, 11:17 AM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1616

  11. Alexander Opitz voted on patch set 3 V +1 CR +1 01/08/18, 10:15

  12. Stefan Neufeind commented on patch set 3 01/28/18, 12:37

    @StephanG: I read you suggest to rework this patch again? Let's finish this beast together then so we can get it off our plate.
  13. Stephan Großberndt commented on patch set 3 01/28/18, 12:59

    No, in my opinion its good like that (+1). My last comment was just what I had in mind with the changes between PS2 and PS3.
  14. Stefan Neufeind commented on patch set 3 V +2 CR +2 01/28/18, 13:54

    Thanks. Looks fine imho, also compared to master again. Let's have it then.
  15. Stefan Neufeind merged patch set 4 01/28/18, 13:54