Review main Merged

55229[TASK] Add section for translated pages to lowlevel statistics page

Anja Leichsenring CR +2 V +2 Easy +27 −3 updated 01/02/18, 21:51

Commit message

Since table pages holds both default language and translated records,
the statistics don't add up anymore.
By introducing a dedicated value count for translated pages, the
sums are equal with the page tree again.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Georg Ringer +1
  • Verified V +2
    • Jigal van Hemert +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Anja Leichsenring uploaded patch set 1 12/29/17, 08:47

  2. Anja Leichsenring commented on patch set 1 12/29/17, 08:47

    see this as a suggestion how to cope with the statistics situation. I will happily implement more dedicated stats if requested.
  3. TYPO3com voted on patch set 1 V +1 12/29/17, 08:56 Completed build in 09m 44s on Fri, 29 Dec, 09:56 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17995

  4. Georg Ringer commented on patch set 1 CR -1 12/29/17, 19:44

    DatabaseIntegrityCheck.php:59 Unresolved

    please make it protected and use a getter. just because the current code is bad, there is no need to make new code as bad
  5. Anja Leichsenring uploaded patch set 2 01/02/18, 08:31

  6. TYPO3com voted on patch set 2 V +1 01/02/18, 08:39 Completed build in 07m 26s on Tue, 2 Jan, 09:39 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18015

  7. Georg Ringer voted on patch set 2 V +1 CR +1 01/02/18, 09:11

  8. Alexander Opitz commented on patch set 2 01/02/18, 14:58

    DatabaseIntegrityCheck.php:59

    Doubling the Word "page" not necessary IMHO.
  9. Jigal van Hemert voted on patch set 2 V +2 CR +2 01/02/18, 21:51

  10. Jigal van Hemert merged patch set 3 01/02/18, 21:51