Review TYPO3_8-7 Merged

55233[BUGFIX] Refresh page tree after context menu actions are completed

Tymoteusz Motylewski CR +2 V +2 Easy +18 −14 updated 01/10/18, 12:49

Commit message

Instead of hardcoded 500ms delay, context menu actions refresh page tree
as soon as the operation is completed.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Tymoteusz Motylewski uploaded patch set 1 12/29/17, 22:53

  2. Tymoteusz Motylewski commented on patch set 1 12/29/17, 22:55

    this change is needed only for v8 as it was fixed in master in different change - https://review.typo3.org/#/c/51594/
  3. TYPO3com voted on patch set 1 V +1 12/29/17, 23:03 Completed build in 09m 50s on Sat, 30 Dec, 12:03 AM Test Summary: 57829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1587

  4. Andreas Kienast commented on patch set 1 V -1 01/01/18, 19:54

    This patch does not work for me: Uncaught TypeError: Cannot read property 'done' of undefined
  5. Andreas Kienast uploaded patch set 2 01/01/18, 20:19

  6. TYPO3com voted on patch set 2 V +1 01/01/18, 20:30 Completed build in 10m 47s on Mon, 1 Jan, 09:30 PM Test Summary: 57829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1589

  7. Tymoteusz Motylewski commented on patch set 2 01/03/18, 08:38

    ah, you're right, in master setUrl returns a deferred
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 01/04/18, 14:24

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 01/10/18, 12:49

  10. Andreas Kienast merged patch set 3 01/10/18, 12:49