Review main Merged

55234[FEATURE] EXT:Scheduler: Create task group from add/edit task form

Michael Oehlhof CR +2 V +2 Normal +96 −8 updated 02/23/18, 14:58

Commit message

Review

  • Code review CR +2
    • Frans Saris +2
    • Frank Nägler +1
    • Jörg Bösche +1
  • Verified V +2
    • Frans Saris +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1823

  1. Michael Oehlhof uploaded patch set 1 12/30/17, 12:41

  2. Michael Oehlhof updated the commit message in patch set 2 12/30/17, 12:42

  3. TYPO3com voted on patch set 2 V +1 12/30/17, 12:49 Completed build in 07m 10s on Sat, 30 Dec, 01:49 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18006

  4. TYPO3com voted on patch set 1 V +1 12/30/17, 12:50 Completed build in 09m 25s on Sat, 30 Dec, 01:50 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18005

  5. Oliver Klee commented on patch set 2 12/30/17, 14:09

    AFAIK, 8.7 and 7.6 don't get new features anymore.
  6. Michael Oehlhof updated the commit message in patch set 3 12/30/17, 22:52

  7. TYPO3com voted on patch set 3 V +1 12/30/17, 23:01 Completed build in 08m 44s on Sun, 31 Dec, 12:01 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18009

  8. Stefan Neufeind commented on patch set 3 CR -1 01/03/18, 15:58

    EditTask.html:1

    That means we need a dep for EXT:beuser in ext_emconf.php, right? Currently that viewhelper was only used from within EXT:beuser.
  9. Stefan Neufeind voted on patch set 3 V +1 01/03/18, 16:07

  10. Anja Leichsenring commented on patch set 3 01/03/18, 20:12

    EditTask.html:1 Reply

    I would suggest to move the VH class into a more generic position like backend or fluid, that is already required by both consuming extensions.
  11. Michael Oehlhof uploaded patch set 4 01/03/18, 22:44

  12. TYPO3com voted on patch set 4 V +1 01/03/18, 22:51 Completed build in 07m 22s on Wed, 3 Jan, 11:51 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18050

  13. Stefan Neufeind commented on patch set 4 CR -1 01/04/18, 07:50

    Imho we can't simply move the ViewHelper out of EXT:beuser but would need to replace it with a proper deprecation. Also I think we should do this move (and the same for other VH maybe in the same go?) as a separate patch. That helps reviewing which changes took place because of the VH-move and makes reviewing this patchset here easier as well.
  14. Stefan Neufeind commented on patch set 4 01/06/18, 13:14

    Georg mentioned on Slack that EXT:fluid is "about to vanish". Maybe we should move at least BE-related ViewHelpers from there to EXT:backend as well? Since the beuser-VH used here is marked "@internal" we might potentially decide to do the move without a deprecation etc. Let's discuss the proper place for BE-related ViewHelpers next week during our on-site-meeting and prepare a separate patch for that first.
  15. Michael Oehlhof commented on patch set 4 02/04/18, 11:51

    I would like to copy the EditRecordViewHelper to the scheduler extension to get rid of the dependencies to other extensions. When the BE ViewHelper are consolidated later we can remove the EditRecordViewHelper from the scheduler extension and use the one of the consolidated backend ViewHelper.
  16. Michael Oehlhof uploaded patch set 5 02/06/18, 23:19

  17. TYPO3com voted on patch set 5 V +1 02/06/18, 23:27 Completed build in 08m 14s on Wed, 7 Feb, 12:27 AM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19057

  18. Frans Saris commented on patch set 5 CR +1 02/22/18, 20:56

    Is it correct that I don't see the add button in the documentation screenshot?
  19. Jörg Bösche voted on patch set 5 CR +1 02/23/18, 08:23

  20. Michael Oehlhof commented on patch set 5 02/23/18, 10:49

    @Frans: In the Screenshot typo3/sysext/scheduler/Documentation/Images/AddingATask.png there is a "+" at the right end of the combo box.
  21. Frank Nägler voted on patch set 5 V +1 CR +1 02/23/18, 13:33

  22. Frans Saris commented on patch set 5 V +2 CR +2 02/23/18, 14:58

    Mobile showed me only the old image...
  23. Frans Saris merged patch set 6 02/23/18, 14:58