Review main Merged

55253[BUGFIX] Exclude fields without db field from advanced search

Reiner Teubner CR +2 V +2 Easy +4 −0 updated 01/04/18, 11:37

Commit message

In advanced search, each field of every table that is listed in TCA
can be used to compose db queries. But if the TCA field has no
counterpart in db, the query fails.
Removing fields that are defined as type user, but without a
defined userfunc are now excluded from view to prevent this kind of
error.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Reiner Teubner uploaded patch set 1 01/03/18, 17:01

  2. Reiner Teubner updated the commit message in patch set 2 01/03/18, 17:04

  3. TYPO3com voted on patch set 1 V +1 01/03/18, 17:11 Completed build in 10m 25s on Wed, 3 Jan, 06:11 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18040

  4. TYPO3com voted on patch set 2 V +1 01/03/18, 17:12 Completed build in 07m 54s on Wed, 3 Jan, 06:12 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18041

  5. Markus Klein voted on patch set 2 CR +1 01/03/18, 19:02

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/03/18, 20:12

  7. Anja Leichsenring commented on patch set 2 01/03/18, 20:14

    you will also need https://review.typo3.org/c/55213/ to test this patch, after advanced search is currently broken.
  8. Christian Kuhn voted on patch set 2 V +2 CR +2 01/04/18, 11:37

  9. Christian Kuhn merged patch set 3 01/04/18, 11:37

  10. Christian Kuhn commented on patch set 3 01/04/18, 11:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a4f75240c4c7c827cbfd8e1a0cc566bcc5b9083f