Review main Merged

55254[FEATURE] Show the field name for every FormEngine field if debug is enabled

Georg Ringer CR +2 V +2 Easy +45 −1 updated 01/04/18, 07:46

Commit message

Improve the life of integrators and developers by showing the field name
next to the title.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1417

  1. Georg Ringer uploaded patch set 1 01/03/18, 19:22

  2. Georg Ringer commented on patch set 1 01/03/18, 19:25

    FYI twitter feedback for the solution as extension is already great https://twitter.com/georg_ringer/status/948556521880858625
  3. Anja Leichsenring commented on patch set 1 V +1 CR +1 01/03/18, 19:30

    so easy, and yet so useful. Thank you Markus.
  4. TYPO3com voted on patch set 1 V -1 01/03/18, 19:32 Completed build in 09m 45s on Wed, 3 Jan, 08:32 PM Test Summary: 9 of 30160 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18043

  5. Anja Leichsenring commented on patch set 1 01/03/18, 19:33

    > Thank you Markus. oh shame, sorry Georg. Georg !== Markus. Sorry. this will be correct: Thank you Georg!
  6. Markus Klein commented on patch set 1 01/03/18, 19:38

    PaletteAndSingleContainer.php:381

    not needed
  7. Georg Ringer uploaded patch set 2 01/03/18, 19:39

  8. Georg Ringer commented on patch set 2 01/03/18, 19:40

    PaletteAndSingleContainer.php:381 Reply

    that can be set to any arbitray value in e.g. AdditionalConfiguration, so I would prefer that still
  9. TYPO3com voted on patch set 2 V +1 01/03/18, 19:46 Completed build in 07m 35s on Wed, 3 Jan, 08:46 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18044

  10. Wouter Wolters voted on patch set 2 CR +1 01/03/18, 19:54

  11. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/03/18, 19:59

  12. Markus Klein commented on patch set 1 01/03/18, 20:12

    PaletteAndSingleContainer.php:381 Reply

    Yes, and it does not matter. Whatever comes along here will be converted to bool anyways, since PHP has to evaluate a condition. ;-)
  13. Georg Ringer uploaded patch set 3 01/03/18, 20:25

  14. TYPO3com voted on patch set 3 V +1 01/03/18, 20:32 Completed build in 06m 59s on Wed, 3 Jan, 09:32 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18047

  15. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/03/18, 20:41

  16. Stefan Neufeind voted on patch set 3 V +2 CR +2 01/04/18, 07:46

  17. Stefan Neufeind merged patch set 4 01/04/18, 07:46