55254[FEATURE] Show the field name for every FormEngine field if debug is enabled
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Anja Leichsenring +1
-
Verified V +2
- Stefan Neufeind +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php3+15 −0
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+7 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-83461-ShowFieldnameNextToTitleInDebugMode.rstnew+22 −0
Review log 1417
-
Georg Ringer uploaded patch set 1 01/03/18, 19:22
-
Georg Ringer commented on patch set 1 01/03/18, 19:25
FYI twitter feedback for the solution as extension is already great https://twitter.com/georg_ringer/status/948556521880858625 -
Anja Leichsenring commented on patch set 1 V +1 CR +1 01/03/18, 19:30
so easy, and yet so useful. Thank you Markus. -
TYPO3com voted on patch set 1 V -1 01/03/18, 19:32 Completed build in 09m 45s on Wed, 3 Jan, 08:32 PM Test Summary: 9 of 30160 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18043
-
Anja Leichsenring commented on patch set 1 01/03/18, 19:33
> Thank you Markus. oh shame, sorry Georg. Georg !== Markus. Sorry. this will be correct: Thank you Georg! -
Markus Klein commented on patch set 1 01/03/18, 19:38
PaletteAndSingleContainer.php:381not needed -
Georg Ringer uploaded patch set 2 01/03/18, 19:39
-
Georg Ringer commented on patch set 2 01/03/18, 19:40
PaletteAndSingleContainer.php:381Replythat can be set to any arbitray value in e.g. AdditionalConfiguration, so I would prefer that still -
TYPO3com voted on patch set 2 V +1 01/03/18, 19:46 Completed build in 07m 35s on Wed, 3 Jan, 08:46 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18044
-
Wouter Wolters voted on patch set 2 CR +1 01/03/18, 19:54
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 01/03/18, 19:59
-
Markus Klein commented on patch set 1 01/03/18, 20:12
PaletteAndSingleContainer.php:381ReplyYes, and it does not matter. Whatever comes along here will be converted to bool anyways, since PHP has to evaluate a condition. ;-) -
Georg Ringer uploaded patch set 3 01/03/18, 20:25
-
TYPO3com voted on patch set 3 V +1 01/03/18, 20:32 Completed build in 06m 59s on Wed, 3 Jan, 09:32 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18047
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 01/03/18, 20:41
-
Stefan Neufeind voted on patch set 3 V +2 CR +2 01/04/18, 07:46
-
Stefan Neufeind merged patch set 4 01/04/18, 07:46