Review main Merged

55262[TASK] Cleanup setting value $SET

Reiner Teubner CR +2 V +2 Easy +8 −12 updated 01/04/18, 11:29

Commit message

For consistent usage the variable $SET was deleted 
and replaced with $this->setting.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Reiner Teubner uploaded patch set 1 01/04/18, 11:03

  2. TYPO3com voted on patch set 1 V +1 01/04/18, 11:10 Completed build in 06m 59s on Thu, 4 Jan, 12:10 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18073

  3. Reiner Teubner updated the commit message in patch set 2 01/04/18, 11:18

  4. Reiner Teubner updated the commit message in patch set 3 01/04/18, 11:18

  5. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/04/18, 11:19

  6. TYPO3com voted on patch set 2 V +1 01/04/18, 11:28 Completed build in 09m 59s on Thu, 4 Jan, 12:28 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18074

  7. TYPO3com voted on patch set 3 V +1 01/04/18, 11:28 Completed build in 09m 41s on Thu, 4 Jan, 12:28 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18075

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 01/04/18, 11:29

  9. Christian Kuhn merged patch set 4 01/04/18, 11:29