Review main Merged

55268[TASK] Introduce Matcher for required arguments in static calls

Anja Leichsenring CR +2 V +2 Hard +383 −2 updated 01/12/18, 11:53

Commit message

Add a matcher that is able to detect hits of method calls that do
not comply to a minimum amount of arguments, where new arguments
have been introduced or previously optional ones have been made
mandatory.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Reiner Teubner +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1621

  1. Anja Leichsenring uploaded patch set 1 01/04/18, 16:19

  2. Anja Leichsenring uploaded patch set 2 01/04/18, 16:21

  3. TYPO3com voted on patch set 1 V +1 01/04/18, 16:27 Completed build in 07m 37s on Thu, 4 Jan, 05:27 PM Test Summary: 30023 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18094

  4. TYPO3com voted on patch set 2 V +1 01/04/18, 16:31 Completed build in 09m 47s on Thu, 4 Jan, 05:31 PM Test Summary: 30023 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18095

  5. Christian Kuhn commented on patch set 2 01/04/18, 20:44

    hey. since the install tool code and thus the ext scanner is mostly internal code, i think we can make this patch a [task] and remove the feature.rst file - we hadn't had feature.rst's for other matchers either, so this should be ok.
  6. Stefan Neufeind uploaded patch set 3 01/05/18, 07:14

  7. Stefan Neufeind commented on patch set 3 01/05/18, 07:14

    resolved conflict, turned it into a task (as Lolli suggeted)
  8. TYPO3com voted on patch set 3 V +1 01/05/18, 07:21 Completed build in 06m 36s on Fri, 5 Jan, 08:21 AM Test Summary: 30023 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18101

  9. Christian Kuhn commented on patch set 3 01/08/18, 21:02

    let's give the comments some love, other than that this matcher looks good.

    MethodArgumentRequiredStaticMatcher.php:25

    that comment is not correct.

    MethodArgumentRequiredStaticMatcher.php:44

    please update comment.

    MethodArgumentRequiredStaticMatcher.php:64

    please add a comment that the maximumNumberOfArguments test is just a measure against false positives.

    MethodArgumentRequiredStaticMatcher.php:88

    please update comment.

    MethodArgumentRequiredStaticMatcher.php:91

    please add a comment that 'maximumNumberOfArguments' is just an additional measure against false positives, this is an artifical restriction.

    MethodArgumentRequiredStaticMatcherFixture.php:38

    invalid comment.
  10. Anja Leichsenring uploaded patch set 4 01/09/18, 17:35

  11. TYPO3com voted on patch set 4 V +1 01/09/18, 17:43 Completed build in 08m 05s on Tue, 9 Jan, 06:43 PM Test Summary: 30021 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18186

  12. Stefan Neufeind voted on patch set 4 CR +1 01/09/18, 18:18

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 01/11/18, 20:25

  14. Reiner Teubner voted on patch set 4 V +1 CR +1 01/12/18, 11:22

  15. Stefan Neufeind voted on patch set 4 V +1 01/12/18, 11:30

  16. Reiner Teubner commented on patch set 5 01/12/18, 11:35

    Published edit on patch set 4.
  17. TYPO3com voted on patch set 5 V +1 01/12/18, 11:39 Completed build in 03m 52s on Fri, 12 Jan, 12:39 PM Test Summary: 28732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18250

  18. Reiner Teubner voted on patch set 5 V +1 CR +1 01/12/18, 11:44

  19. Christian Kuhn voted on patch set 5 V +2 CR +2 01/12/18, 11:44

  20. Christian Kuhn merged patch set 6 01/12/18, 11:44

  21. Stefan Neufeind voted on patch set 6 V +1 CR +1 01/12/18, 11:53