Review main Merged

55269[BUGFIX] Add +repage option when cropping images

Frans Saris CR +2 V +2 Easy +2 −2 updated 03/02/18, 06:04

Commit message

To be sure the image (especialy gif format) is correctly repaged after
cropping it the +repage option needs to be added to the full command.

This patch adds the option for the LocalCropScaleMaskHelper and the
ImageBuilder cropscaling `crs` option.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Frans Saris uploaded patch set 1 01/04/18, 20:16

  2. TYPO3com voted on patch set 1 V +1 01/04/18, 20:25 Completed build in 08m 51s on Thu, 4 Jan, 09:25 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18099

  3. Christian Kuhn commented on patch set 1 01/24/18, 17:16

    GraphicalFunctions.php:2121

    it looks to me as if .jpg and other formats run through this, too. is this option safe to be added here?
  4. Frans Saris commented on patch set 1 01/24/18, 18:56

    Yes this is done for all formats. In my test runs this didn't give any issues
  5. Frans Saris rebased onto patch set 2 01/26/18, 09:04

  6. TYPO3com voted on patch set 2 V +1 01/26/18, 09:15 Completed build in 10m 32s on Fri, 26 Jan, 10:15 AM Test Summary: 30301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18613

  7. Andreas Wolf commented on patch set 2 01/27/18, 10:27

    Any chance to get a test for this done? Could we check the output of a command with e.g. identify?
  8. Frans Saris commented on patch set 2 01/27/18, 10:35

    > Patch Set 2: > > Any chance to get a test for this done? Could we check the output of a command with e.g. identify? Yes we need some tests for this. But for now we don't have any base for this. Not sure if we should burden this patch with this improvement. Further we should also find something to test the output of these commands with different versions of IM and GM
  9. Mathias Schreiber voted on patch set 2 V +1 CR +1 03/01/18, 22:24

  10. Christian Kuhn commented on patch set 2 03/01/18, 22:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 44278cfb8ed8c4e259a445669999e12b5bdd43c2
  11. Christian Kuhn voted on patch set 2 V +2 CR +2 03/01/18, 22:27

  12. Christian Kuhn merged patch set 3 03/01/18, 22:27

  13. Frans Saris commented on patch set 3 03/02/18, 06:04

    Tnx for getting this in