55276[BUGFIX] Add missing htmlspecialchars() in ActionTask
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Oliver Klee +1
- Stephan Großberndt +1
-
Verified V +2
- Christian Kuhn +2
- Alexander Opitz +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1721
-
Stefan Neufeind uploaded patch set 1 01/05/18, 12:40
-
Stefan Neufeind commented on patch set 1 01/05/18, 12:41
hand-redone for 8.7. please check -
Oliver Klee voted on patch set 1 CR +1 01/05/18, 12:43
-
TYPO3com voted on patch set 1 V +1 01/05/18, 12:46 Completed build in 05m 11s on Fri, 5 Jan, 01:46 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1617
-
Stephan Großberndt commented on patch set 1 CR -1 01/05/18, 12:50
ActionTask.php:944$uriBuilder is undefined -
Stefan Neufeind uploaded patch set 2 01/05/18, 17:33
-
Stephan Großberndt commented on patch set 2 01/05/18, 17:39
ActionTask.php:918Sorry Stefan, I should have written more than that. Rather than introduction uriBuilder here (in a different way than on master) I would opt for further usage of BackendUtility instead. This patch aims at htmlspecialchars. -
TYPO3com voted on patch set 2 V +1 01/05/18, 17:47 Completed build in 13m 16s on Fri, 5 Jan, 06:47 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1618
-
Stefan Neufeind uploaded patch set 3 01/06/18, 14:50
-
Stefan Neufeind commented on patch set 3 01/06/18, 14:50
yes, agreed. now with BackendUtility -
TYPO3com voted on patch set 3 V +1 01/06/18, 14:59 Completed build in 09m 13s on Sat, 6 Jan, 03:59 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1619
-
Oliver Klee voted on patch set 3 CR +1 01/06/18, 15:19
-
Alexander Opitz commented on patch set 3 CR -1 01/08/18, 10:08
Only the small indentation bug (master patch has this indentation issue in reverse ;-) )ActionTask.php:944Indentation failure? -
Stephan Großberndt uploaded patch set 4 01/08/18, 12:15
-
Stephan Großberndt voted on patch set 4 CR +1 01/08/18, 12:16
-
TYPO3com voted on patch set 4 V +1 01/08/18, 12:28 Completed build in 12m 45s on Mon, 8 Jan, 01:28 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1624
-
Alexander Opitz voted on patch set 4 V +1 CR +2 01/08/18, 13:07
-
Oliver Klee voted on patch set 4 CR +1 01/08/18, 13:12
-
Stefan Neufeind voted on patch set 4 CR +1 01/08/18, 13:16
-
Christian Kuhn voted on patch set 4 V +2 CR +2 01/08/18, 20:26
-
Christian Kuhn merged patch set 5 01/08/18, 20:26