Review main Merged

55278[TASK] Cleanup StringValidatorTest

Alexander Schnitzler CR +2 V +2 Easy +25 −25 updated 01/08/18, 19:42

Commit message

- Replace eval with anonymous classes
- Avoid mocks if not necessary

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Reiner Teubner +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Alexander Schnitzler uploaded patch set 1 01/05/18, 13:23

  2. TYPO3com voted on patch set 1 V +1 01/05/18, 13:29 Completed build in 06m 20s on Fri, 5 Jan, 02:29 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18115

  3. Alexander Schnitzler uploaded patch set 2 01/05/18, 13:56

  4. TYPO3com voted on patch set 2 V +1 01/05/18, 14:03 Completed build in 07m 45s on Fri, 5 Jan, 03:03 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18118

  5. Stephan Großberndt commented on patch set 2 01/05/18, 14:52

    StringValidatorTest.php:5

    I am quite sure its not allowed to change the copyright here. Once upon a time I prepared an according patch which was denied...
  6. Alexander Schnitzler uploaded patch set 3 01/08/18, 09:25

  7. TYPO3com voted on patch set 3 V +1 01/08/18, 09:33 Completed build in 08m 28s on Mon, 8 Jan, 10:33 AM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18150

  8. Georg Ringer voted on patch set 3 V +1 CR +1 01/08/18, 13:23

  9. Reiner Teubner voted on patch set 3 V +1 CR +1 01/08/18, 13:55

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 01/08/18, 19:42

  11. Christian Kuhn merged patch set 4 01/08/18, 19:42