Review main Merged

55285[BUGFIX] New content element wizard fails for not given header value

Steffen Kamper CR +2 V +2 Easy +2 −2 updated 01/09/18, 08:38

Commit message

As additional sanitation, accept an empty header for items groups
by rendering "-" if none is given.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1620

  1. Steffen Kamper uploaded patch set 1 01/06/18, 11:41

  2. Steffen Kamper commented on patch set 1 01/06/18, 11:45

    I didn't checked 8_7 or 7_6 if the bug is there too
  3. TYPO3com voted on patch set 1 V +1 01/06/18, 11:49 Completed build in 08m 01s on Sat, 6 Jan, 12:49 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18129

  4. Andreas Kienast commented on patch set 1 01/06/18, 13:34

    NewContentElementWizardController.php:272 Unresolved

    Can be shortened to `$wizardInformation['header'] ?: '-';`
  5. Steffen Kamper uploaded patch set 2 01/07/18, 11:20

  6. TYPO3com voted on patch set 2 V +1 01/07/18, 11:27 Completed build in 06m 28s on Sun, 7 Jan, 12:27 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18142

  7. Oliver Klee voted on patch set 2 CR +1 01/07/18, 12:27

  8. Oliver Klee updated the commit message in patch set 3 01/07/18, 12:29

  9. Oliver Klee voted on patch set 3 CR +1 01/07/18, 12:29

  10. Oliver Klee commented on patch set 3 01/07/18, 12:29

    Are 8.7 and 7.6 affected as well?
  11. TYPO3com voted on patch set 3 V +1 01/07/18, 12:35 Completed build in 06m 12s on Sun, 7 Jan, 01:35 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18143

  12. Andreas Kienast voted on patch set 3 CR +1 01/08/18, 09:34

  13. Reiner Teubner voted on patch set 3 V +1 CR +1 01/08/18, 12:28

  14. Tymoteusz Motylewski commented on patch set 3 01/08/18, 12:56

    correctly
  15. Christian Kuhn uploaded patch set 4 01/08/18, 20:41

  16. Christian Kuhn commented on patch set 4 01/08/18, 20:41

    prepared and pushed the backport to 8.7. not critical for 7.6.
  17. Christian Kuhn voted on patch set 4 V +1 CR +1 01/08/18, 20:41

  18. TYPO3com voted on patch set 4 V +1 01/08/18, 20:50 Completed build in 08m 58s on Mon, 8 Jan, 09:50 PM Test Summary: 30003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18173

  19. Andreas Kienast voted on patch set 4 V +2 CR +2 01/09/18, 08:36

  20. Andreas Kienast merged patch set 5 01/09/18, 08:38