Review main Merged

55287[TASK] Update karma components

Frank Nägler CR +2 V +2 Easy +4 −4 updated 01/08/18, 20:11

Commit message

karma-firefox-launcher 1.0.1 ❯ 1.1.0
karma-jasmine 1.1.0 ❯ 1.1.1

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Frank Nägler uploaded patch set 1 01/06/18, 11:58

  2. TYPO3com voted on patch set 1 V +1 01/06/18, 12:05 Completed build in 06m 29s on Sat, 6 Jan, 01:05 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18131

  3. Andreas Kienast commented on patch set 1 V +1 CR +1 01/08/18, 19:55

    Relying on Bamboo giving a +1
  4. Christian Kuhn commented on patch set 1 V +2 CR +2 01/08/18, 20:11

    that's basically a "if tests still succeed, all is fine".
  5. Christian Kuhn merged patch set 2 01/08/18, 20:11