Review main Merged

55294[TASK] Deprecate unneeded RawValidator

Alexander Schnitzler CR +2 V +2 Normal +52 −2 updated 01/08/18, 10:34

Commit message

The RawValidator is a useless Validator that is
automatically attached to all method params that
are annotated with "@param mixed".

This is due to the recognition of the pseudo type
"mixed" in ValidatorResolver::getValidatorType which
converts mixed into Raw and which then is responsible
for creating that RawValidator for the param.

However, this is completely useless as the Validator
does not validate. Hence, it will be deprecated and
removed in TYPO3 v10.0 without any replacement.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Henning Liebe +1
    • Eugene Kenah Djomo +1
  • Verified V +2
    • Georg Ringer +2
    • Eugene Kenah Djomo +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 89

  1. Alexander Schnitzler uploaded patch set 1 01/07/18, 13:51

  2. TYPO3com voted on patch set 1 V +1 01/07/18, 13:58 Completed build in 06m 30s on Sun, 7 Jan, 02:58 PM Test Summary: 30003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18144

  3. Oliver Klee voted on patch set 1 CR +1 01/07/18, 14:03

  4. Henning Liebe voted on patch set 1 CR +1 01/08/18, 08:57

  5. Eugene Kenah Djomo voted on patch set 1 CR +1 01/08/18, 10:15

  6. Georg Ringer voted on patch set 1 V +2 CR +2 01/08/18, 10:31

  7. Georg Ringer merged patch set 2 01/08/18, 10:31

  8. Eugene Kenah Djomo voted on patch set 1 V +1 01/08/18, 10:32

  9. Eugene Kenah Djomo voted on patch set 2 V +1 01/08/18, 10:34