Review TYPO3_8-7 Merged

55306[BUGFIX] EXT:form - add compatibility for issue #82210

Ralf Zimmermann CR +2 V +2 Normal +63 −1 updated 02/05/18, 13:56

Commit message

The fix for issue #82210 implies a breaking change within a minor
release (template changes) and was never documented.

This bugfix adds some compatibility code for integrators who are using
their own templates for RadioButton and/ or MultiCheckbox form elements.

In addition, a deprecation warning is thrown and the corresponding rst
file has been added.

A different patchset adds the appropriate breaking rst file for v9.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Tobi Kretschmann +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2
    • Oliver Hader +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1721

  1. Ralf Zimmermann uploaded patch set 1 01/09/18, 13:08

  2. TYPO3com voted on patch set 1 V +1 01/09/18, 13:21 Completed build in 13m 05s on Tue, 9 Jan, 02:21 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1627

  3. Björn Jacob commented on patch set 2 01/10/18, 07:32

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 01/10/18, 07:39 Completed build in 07m 45s on Wed, 10 Jan, 08:39 AM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1635

  5. Daniel Gohlke voted on patch set 2 CR +1 01/15/18, 08:05

  6. Mathias Brodala commented on patch set 3 02/01/18, 09:29

    Published edit on patch set 2.
  7. Mathias Brodala commented on patch set 3 02/01/18, 09:30

    TranslateElementPropertyViewHelper.php:89

    Can't we just use the $propertyParts from the explode() as is?
  8. TYPO3com voted on patch set 3 V +1 02/01/18, 09:45 Completed build in 15m 11s on Thu, 1 Feb, 10:45 AM Test Summary: 57881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1712

  9. Ralf Zimmermann commented on patch set 3 02/02/18, 15:31

    TranslateElementPropertyViewHelper.php:89 Reply

    If you use quotes within the value (https://forge.typo3.org/issues/82210#note-16) like - type: RadioButton identifier: radiobutton-1 label: 'Radio button' properties: options: '"bar.foo"': 'foo."bar"' the result of $propertyParts is array(3 items) 0 => 'options' (7 chars) 1 => '"bar' (9 chars) 2 => 'foo"' (9 chars) which is wrong. with the array_shift foo, the result is array(2 items) 0 => 'options' (7 chars) 1 => '"bar.foo"' (9 chars) which is right.
  10. Mathias Brodala commented on patch set 3 02/02/18, 15:44

    TranslateElementPropertyViewHelper.php:89 Reply

    Alright, thanks for clarifying.
  11. Anja Leichsenring commented on patch set 3 02/02/18, 16:33

    Deprecation-83403-ExtFormTranslationForOptionsPropertiesAsString.rst:15

    but deprecated and will be removed with TYPO3 v9 ? if I understood correctly.

    Deprecation-83403-ExtFormTranslationForOptionsPropertiesAsString.rst:25

    this sentence is kind of dublicated.

    Deprecation-83403-ExtFormTranslationForOptionsPropertiesAsString.rst:34

    Multicheckbox or Radiobuttons, right? Both are effected, independently from each other.
  12. Björn Jacob commented on patch set 4 02/03/18, 11:24

    Published edit on patch set 3.
  13. Björn Jacob commented on patch set 3 02/03/18, 11:24

    Deprecation-83403-ExtFormTranslationForOptionsPropertiesAsString.rst:15 Reply Unresolved

    Done

    Deprecation-83403-ExtFormTranslationForOptionsPropertiesAsString.rst:25 Reply Unresolved

    Correct. Removed it.

    Deprecation-83403-ExtFormTranslationForOptionsPropertiesAsString.rst:34 Reply Unresolved

    Done
  14. TYPO3com voted on patch set 4 V +1 02/03/18, 11:33 Completed build in 09m 09s on Sat, 3 Feb, 12:33 PM Test Summary: 57911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1721

  15. Andreas Kienast voted on patch set 4 CR +1 02/05/18, 08:36

  16. Tobi Kretschmann voted on patch set 4 CR +1 02/05/18, 13:22

  17. Oliver Hader commented on patch set 4 CR +1 02/05/18, 13:45

    Will test manually...
  18. Christian Kuhn voted on patch set 4 V +1 CR +1 02/05/18, 13:54

  19. Oliver Hader voted on patch set 4 V +1 02/05/18, 13:55

  20. Oliver Hader voted on patch set 4 V +2 CR +2 02/05/18, 13:56

  21. Oliver Hader merged patch set 5 02/05/18, 13:56