55317[BUGFIX] Rename directory for deprecated unit tests
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Tests/UnitDeprecated/Compatibility/PublicPropertyDeprecationTraitTest.phprenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Html/RteHtmlParserTest.phprenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Utility/ClientUtilityTest.phprenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Utility/ExtensionManagementUtilityTest.phprenamed+0 −0
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManager.php1+4 −3
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/Header.yamldeleted+0 −6
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/ConfigurationManagerTest.php+9 −3
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File1.yamlrenamed+0 −0
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File2.yamlrenamed+0 −0
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File3.yamlrenamed+0 −0
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File4.yamlrenamed+0 −0
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/Header.yamlrenamed+0 −0
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/ConfigurationManagerTest.phprenamed+16 −10
Review log 1418
-
Andreas Kienast uploaded patch set 1 01/10/18, 09:05
-
Andreas Kienast commented on patch set 1 V -1 01/10/18, 09:07
There are some more -
Andreas Kienast uploaded patch set 2 01/10/18, 09:10
-
TYPO3com voted on patch set 1 V +1 01/10/18, 09:14 Completed build in 09m 31s on Wed, 10 Jan, 10:14 AM Test Summary: 30054 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18209
-
TYPO3com voted on patch set 2 V -1 01/10/18, 09:19 Completed build in 08m 53s on Wed, 10 Jan, 10:19 AM Test Summary: 1 of 30216 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18211
-
Ralf Zimmermann uploaded patch set 3 01/11/18, 12:22
-
Ralf Zimmermann voted on patch set 3 CR -1 01/11/18, 12:23
-
Ralf Zimmermann uploaded patch set 4 01/11/18, 12:26
-
TYPO3com voted on patch set 3 V -1 01/11/18, 12:31 Completed build in 09m 18s on Thu, 11 Jan, 01:31 PM Test Summary: 3 of 30216 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18237
-
TYPO3com voted on patch set 4 V +1 01/11/18, 12:33 Completed build in 06m 34s on Thu, 11 Jan, 01:33 PM Test Summary: 30055 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18238
-
Andreas Kienast commented on patch set 4 01/11/18, 12:41
Thanks Ralf for taking care! -
Oliver Klee commented on patch set 4 01/11/18, 13:06
ConfigurationManager.php:105The changes in this file do not seem to belong to changing the namespace. Do we need them here? -
Ralf Zimmermann commented on patch set 4 01/11/18, 13:11
We rebuilt the yaml file loading a few days ago. Nobody looked at the deprecated unittests, so a bug within ext:form was overlooked. Now, we looked at this tests and see that it fails... So I fixed the bug, and now the unittest works ;) I have no idea for another wokflow. -
Oliver Klee commented on patch set 4 01/11/18, 13:44
I propose creating a separate change request with those bug fixes first, and have this namespace-related CR after the first CR is merged. This will help keep the commits on topic and clean. -
Andreas Kienast commented on patch set 4 01/11/18, 13:55
I don't think that a separate patch is necessary. We also don't change any namespace here. This patch actually only fixes the execution of unit tests for deprecated code by renaming the directory, which revealed another bug now. The bugfix is very small and IMO can be handled in the same patch. -
Christian Kuhn commented on patch set 4 V +1 CR +1 01/11/18, 20:13
it's fine to have the code fix along with the renaming in this patch. -
Andreas Kienast voted on patch set 4 V +2 CR +2 01/12/18, 07:22
-
Andreas Kienast merged patch set 5 01/12/18, 07:23