Review main Merged

55335[BUGFIX] Remove empty values from intExplode in TreeController

Tymoteusz Motylewski CR +2 V +2 Easy +1 −1 updated 01/12/18, 09:14

Commit message

intExplode missed an additional parameter which prevents the method 
from returning array with empty element.

Now when doktypesToShowInNewPageDragArea is empty, 
PageTree API will return empty array.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Tymoteusz Motylewski uploaded patch set 1 01/11/18, 16:31

  2. Tymoteusz Motylewski updated the commit message in patch set 2 01/11/18, 16:32

  3. TYPO3com voted on patch set 1 V +1 01/11/18, 16:38 Completed build in 06m 53s on Thu, 11 Jan, 05:38 PM Test Summary: 30003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18241

  4. TYPO3com voted on patch set 2 V +1 01/11/18, 16:40 Completed build in 08m 29s on Thu, 11 Jan, 05:40 PM Test Summary: 30003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18242

  5. Wouter Wolters voted on patch set 2 CR +1 01/11/18, 18:14

  6. Andreas Kienast voted on patch set 2 CR +1 01/11/18, 19:21

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/11/18, 20:29

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 01/12/18, 09:14

  9. Andreas Kienast merged patch set 3 01/12/18, 09:14