Review main Merged

55343[TASK] Drop 'typo3/ should be link' recommendation

Christian Kuhn CR +2 V +2 Hard +163 −185 updated 01/13/18, 12:23

Commit message

The recommendation of FolderStructure having index.php and typo3/
folder as links is old fashioned, even if not using composer
based instances. The config has no functional meaning in the
install tool and can just be dropped.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Anja Leichsenring +1
  • Verified V +2
    • Jigal van Hemert +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/12/18, 19:33

  2. TYPO3com voted on patch set 1 V -1 01/12/18, 19:33 Completed build in 08s on Fri, 12 Jan, 08:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18263

  3. Christian Kuhn uploaded patch set 2 01/12/18, 19:34

  4. TYPO3com voted on patch set 2 V +1 01/12/18, 19:39 Completed build in 04m 22s on Fri, 12 Jan, 08:39 PM Test Summary: 28750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18264

  5. Christian Kuhn commented on patch set 2 01/12/18, 20:57

    note: patch looks worse that it actually is: basically only $structureAdditional is removed, then the array is simplified accordingly.
  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/13/18, 10:49

  7. Jigal van Hemert voted on patch set 2 V +2 CR +2 01/13/18, 11:12

  8. Jigal van Hemert merged patch set 3 01/13/18, 11:12

  9. Christian Kuhn commented on patch set 3 01/13/18, 12:23

    benni asked me to additionally back port this to 8.7