Review main Abandoned

55344[FEATURE] Allow shortening language file paths

Andreas Wolf CR 0 V 0 Nightmare +3644 −3494 updated 02/11/18, 00:04

Commit message

LanguageService now supports to leave out the
`/Resources/Private/Language/` part and replace it by a simple ":",
allowing localization labels to be addressed in the style of
`LLL:EXT:core:locallang.xlf:my.label`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 393

Show 373 more files

Review log 2537

Show 812 earlier messages
  1. Andreas Wolf uploaded patch set 1 01/12/18, 22:26

  2. TYPO3com voted on patch set 1 V -1 01/12/18, 22:26 Completed build in 24s on Fri, 12 Jan, 11:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18266

  3. Andreas Wolf uploaded patch set 2 01/12/18, 22:43

  4. TYPO3com voted on patch set 2 V -1 01/12/18, 22:51 Completed build in 07m 58s on Fri, 12 Jan, 11:51 PM Test Summary: 15 of 28919 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18269

  5. Andreas Wolf uploaded patch set 3 01/14/18, 16:15

  6. TYPO3com voted on patch set 3 V +1 01/14/18, 16:24 Completed build in 08m 45s on Sun, 14 Jan, 05:24 PM Test Summary: 28717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18316

  7. Andreas Wolf uploaded patch set 4 01/14/18, 16:26

  8. TYPO3com voted on patch set 4 V +1 01/14/18, 16:34 Completed build in 08m 20s on Sun, 14 Jan, 05:34 PM Test Summary: 28717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18317

  9. Jörg Bösche commented on patch set 4 V +1 CR +1 01/16/18, 14:24

    Did smoke tests in the backend modules, typoscript and fluid templates. Works like a charm. (TYPO3 CMS 9.1.0-dev)
  10. Christian Kuhn commented on patch set 4 01/18/18, 12:41

    i think we could give the main .rst file a bit more love. however, i like this shorter path - will review in more detail.
  11. Christian Kuhn commented on patch set 4 CR -1 01/18/18, 12:46

    on it.
  12. Christian Kuhn commented on patch set 4 01/18/18, 12:57

    LanguageServiceTest.php:27

    another test would be good-old LLL:EXT:core/locallang.xlf resolves to EXT:core/locallang.xlf
  1. Oliver Hader commented on patch set 4 CR -1 01/18/18, 14:16

    Please do not adjust RST files of previous versions & releases

    LanguageService.php:82

    Please add an example here how the combined label looks like

    Feature-66669-BeLoginFormAPI.rst:30

    Seems to be search and replace result - please do not modify RST files of past releases
  2. Jan Stockfisch commented on patch set 4 01/22/18, 10:29

    I'm on it. But my patchset does not include a combined label example, because I don't known how one does look like. However - love the simplified path!

    Feature-66669-BeLoginFormAPI.rst:30 Reply

    Done

    LanguageServiceTest.php:27 Reply

    Done
  3. Jan Stockfisch voted on patch set 4 V +1 CR -1 01/22/18, 10:30

  4. Jan Stockfisch uploaded patch set 5 01/22/18, 10:46

  5. TYPO3com voted on patch set 5 V +1 01/22/18, 10:54 Completed build in 08m 16s on Mon, 22 Jan, 11:54 AM Test Summary: 30208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18507

  6. Jan Stockfisch uploaded patch set 6 01/22/18, 11:06

  7. TYPO3com voted on patch set 6 V +1 01/22/18, 11:15 Completed build in 08m 22s on Mon, 22 Jan, 12:15 PM Test Summary: 30208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18508

  8. Jörg Bösche voted on patch set 6 V +1 CR +1 01/23/18, 13:19

  9. Christian Kuhn commented on patch set 6 01/23/18, 14:02

    note there is currently a discussion in coreteam whether we want to do the patch, or have a bigger refactoring in this area.
  10. Andreas Wolf uploaded patch set 7 01/25/18, 06:54

  11. Andreas Wolf uploaded patch set 8 01/25/18, 06:57

  12. Andreas Wolf commented on patch set 8 01/25/18, 06:58

    Rebased to fix merge conflict.
  13. Andreas Wolf uploaded patch set 9 01/25/18, 06:59

  14. TYPO3com voted on patch set 7 V +1 01/25/18, 07:00 Completed build in 06m 24s on Thu, 25 Jan, 08:00 AM Test Summary: 30316 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18599

  15. Andreas Wolf commented on patch set 9 01/25/18, 07:00

    Removed some parts that got in again during my rebase. Don't rebase before breakfast and the first coffee… ;-)
  16. TYPO3com voted on patch set 8 V +1 01/25/18, 07:04 Completed build in 06m 35s on Thu, 25 Jan, 08:04 AM Test Summary: 30316 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18600

  17. TYPO3com voted on patch set 9 V +1 01/25/18, 07:08 Completed build in 08m 49s on Thu, 25 Jan, 08:08 AM Test Summary: 30316 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18601

  18. Oliver Hader commented on patch set 9 02/06/18, 20:35

    @Andi: Can you please rebase this one? Thx in advance
  19. Mathias Schreiber uploaded patch set 10 02/06/18, 20:48

  20. TYPO3com voted on patch set 10 V +1 02/06/18, 20:58 Completed build in 10m 23s on Tue, 6 Feb, 09:58 PM Test Summary: 30473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19042

  21. Reiner Teubner uploaded patch set 11 02/08/18, 14:23

  22. TYPO3com voted on patch set 11 V +1 02/08/18, 14:31 Completed build in 08m 01s on Thu, 8 Feb, 03:31 PM Test Summary: 30476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19134

  23. Mathias Schreiber uploaded patch set 12 02/08/18, 18:30

  24. TYPO3com voted on patch set 12 V -1 02/08/18, 18:39 Completed build in 08m 58s on Thu, 8 Feb, 07:39 PM Test Summary: 18 of 30637 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19150

  25. Benni Mack abandoned the change 02/11/18, 00:04

    As decided within the core team, this adds even more magic to this concept, and has some flaws with the TypoScript LOCAL_LANG override. Lets abandon this one for now.