Review main Merged

55349[TASK] Add spaces around '=' of 'strict_types=1'

Christian Kuhn CR +2 V +2 Expert +562 −562 updated 01/13/18, 17:43

Commit message

This cosmetical CGL change just substitutes all

declare(strict_types=1);
with
declare(strict_types = 1);

to be in line with the general 'spaces around ='
rule. While that is cosmetical, it makes scrutinizer-ci
a bit more happy and prevents it from creating
auto-patches for these cases.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 562

Show 542 more files

Review log 911

  1. Christian Kuhn uploaded patch set 1 01/13/18, 14:17

  2. Christian Kuhn voted on patch set 1 CR -2 01/13/18, 14:17

  3. TYPO3com voted on patch set 1 V +1 01/13/18, 14:21 Completed build in 03m 54s on Sat, 13 Jan, 03:21 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18278

  4. Christian Kuhn uploaded patch set 2 01/13/18, 15:08

  5. Christian Kuhn voted on patch set 2 CR 0 01/13/18, 15:08

  6. TYPO3com voted on patch set 2 V +1 01/13/18, 15:16 Completed build in 08m 01s on Sat, 13 Jan, 04:16 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18280

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/13/18, 15:16

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 01/13/18, 15:31

  9. Wouter Wolters merged patch set 3 01/13/18, 15:31

  10. Oliver Klee commented on patch set 3 01/13/18, 17:04

    Should we also run the same autoformat on 8.7 (and maybe 7.6)? This will reduce the risk of cherry-picks of backports failing due to differences in code formatting.
  11. Christian Kuhn commented on patch set 3 01/13/18, 17:43

    ... too lazy for 8.6, in v7 there are no strict_types due to php 5.