Review main Merged

55360[BUGFIX] GeneralUtility::copyDirectory() should mkdir_deep() destination dir

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 01/14/18, 18:37

Commit message

If path to the destination directory does not exist yet,
copyDirectory() does not copy anything. Use mkdir_deep() for directories.

As example, have directory 'typo3temp' and call copyDirectory()
with a destination 'typo3temp/foo/bar', where 'foo' does not
exist, yet. Without patch, this operation fails.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Riccardo De Contardi +1
    • Benjamin Kott +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1315

  1. Christian Kuhn uploaded patch set 1 01/14/18, 17:19

  2. TYPO3com voted on patch set 1 V +1 01/14/18, 17:24 Completed build in 04m 24s on Sun, 14 Jan, 06:24 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18319

  3. Riccardo De Contardi voted on patch set 1 CR +1 01/14/18, 17:51

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 01/14/18, 17:52

  5. Christian Kuhn voted on patch set 1 V -1 CR -2 01/14/18, 18:14

  6. Christian Kuhn uploaded patch set 2 01/14/18, 18:19

  7. TYPO3com voted on patch set 2 V +1 01/14/18, 18:23 Completed build in 04m 15s on Sun, 14 Jan, 07:23 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18321

  8. Christian Kuhn voted on patch set 2 CR 0 01/14/18, 18:24

  9. Benjamin Kott voted on patch set 2 V +1 CR +1 01/14/18, 18:27

  10. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/14/18, 18:28

  11. Riccardo De Contardi voted on patch set 2 CR +1 01/14/18, 18:29

  12. Wouter Wolters voted on patch set 2 CR +1 01/14/18, 18:30

  13. Christian Kuhn voted on patch set 2 V +2 CR +2 01/14/18, 18:37

  14. Christian Kuhn merged patch set 3 01/14/18, 18:37

  15. Christian Kuhn commented on patch set 3 01/14/18, 18:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 52071c6e6e2c9f5dd1ac3d51300c93064602548e