Review TYPO3_8-7 Merged

55361[BUGFIX] GeneralUtility::copyDirectory() should mkdir_deep() destination dir

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 01/14/18, 18:56

Commit message

If path to the destination directory does not exist yet,
copyDirectory() does not copy anything. Use mkdir_deep() for directories.

As example, have directory 'typo3temp' and call copyDirectory()
with a destination 'typo3temp/foo/bar', where 'foo' does not
exist, yet. Without patch, this operation fails.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 01/14/18, 18:37

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/14/18, 18:47 Completed build in 10m 06s on Sun, 14 Jan, 07:47 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1656

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/14/18, 18:56

  4. Christian Kuhn merged patch set 2 01/14/18, 18:56