55363[TASK] Make EXT:rsaauth no longer part of factory-configuration
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- Oliver Klee +1
- Anja Leichsenring +1
- Andreas Kienast +1
-
Verified V +2
- Jigal van Hemert +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1618
-
Stefan Neufeind uploaded patch set 1 01/15/18, 11:17
-
Christian Kuhn voted on patch set 1 CR +1 01/15/18, 11:18
-
Stefan Neufeind commented on patch set 1 01/15/18, 11:19
do we need to adjust additional pre-configuration if rsaauth is no longer active by default? looking ... -
TYPO3com voted on patch set 1 V +1 01/15/18, 11:21 Completed build in 04m 14s on Mon, 15 Jan, 12:21 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18332
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 01/15/18, 11:22
-
Stefan Neufeind commented on patch set 1 01/15/18, 11:23
Should be okay. SilentConfigurationUpgradeService only sets loginSecurityLevel to "rsa" if EXT:rsaauth is loaded. So it will default to "normal" on a clean install now. -
Markus Klein voted on patch set 1 CR +1 01/15/18, 12:04
-
Christian Kuhn commented on patch set 1 01/15/18, 12:18
note: please check typo3/minimal composer metapackage, too. -
Markus Klein commented on patch set 1 01/15/18, 12:41
@Lolli: Is not affected: https://github.com/TYPO3/minimal/blob/master/composer.json -
Markus Klein voted on patch set 1 CR -1 01/15/18, 12:44
-
Markus Klein uploaded patch set 2 01/15/18, 12:45
-
TYPO3com voted on patch set 2 V +1 01/15/18, 12:49 Completed build in 04m 07s on Mon, 15 Jan, 01:49 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18337
-
Stefan Neufeind commented on patch set 2 CR +1 01/15/18, 13:06
@Markus: thanks. I looked that up in DefaultConfiguration and then expected that the SilentUpdater would set rsa/normal instead -
Oliver Klee voted on patch set 2 CR +1 01/15/18, 13:23
-
Andreas Kienast voted on patch set 2 CR +1 01/15/18, 14:01
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 01/15/18, 15:35
-
Jigal van Hemert voted on patch set 2 V +2 CR +2 01/15/18, 23:02
-
Jigal van Hemert merged patch set 3 01/15/18, 23:02