Review main Abandoned

55366[FEATURE] Add RemoveRecordUriViewHelper in sysext:backend

Reiner Teubner CR 0 V 0 Normal +100 −0 updated 01/17/18, 16:57

Commit message

Add a Backend ViewHelper that returns an uri for deleting a single record.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1522

  1. Reiner Teubner uploaded patch set 1 01/15/18, 16:52

  2. TYPO3com voted on patch set 1 V -1 01/15/18, 16:52 Completed build in 08s on Mon, 15 Jan, 05:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18343

  3. Reiner Teubner uploaded patch set 2 01/15/18, 16:54

  4. TYPO3com voted on patch set 2 V +1 01/15/18, 17:00 Completed build in 06m 23s on Mon, 15 Jan, 06:00 PM Test Summary: 30055 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18344

  5. Wouter Wolters commented on patch set 2 01/15/18, 17:26

    RemoveRecordViewHelper.php:1 Unresolved

    could you make this new class strict?
  6. Reiner Teubner voted on patch set 2 V -1 01/15/18, 17:38

  7. Georg Ringer commented on patch set 2 01/16/18, 08:25

    Feature-83574-FEATUREAddRemoveRecordViewHelperInSysextbackend.rst:4 Unresolved

    the [FEATURE] is not needed here

    Feature-83574-FEATUREAddRemoveRecordViewHelperInSysextbackend.rst:14 Unresolved

    please add an example
  8. Andreas Kienast commented on patch set 2 01/16/18, 11:47

    RemoveRecordViewHelper.php:36 Unresolved

    Hm, the ViewHelper generates a HTML tag. Isn't using the `AbstractTagBasedViewHelper` a better choice here?
  9. Reiner Teubner rebased onto patch set 3 01/16/18, 13:06

  10. TYPO3com voted on patch set 3 V +1 01/16/18, 13:18 Completed build in 11m 53s on Tue, 16 Jan, 02:18 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18358

  11. Reiner Teubner uploaded patch set 4 01/16/18, 13:25

  12. Reiner Teubner uploaded patch set 5 01/16/18, 13:28

  13. TYPO3com voted on patch set 4 V +1 01/16/18, 13:32 Completed build in 07m 21s on Tue, 16 Jan, 02:32 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18366

  14. Reiner Teubner uploaded patch set 6 01/16/18, 13:35

  15. TYPO3com voted on patch set 5 V +1 01/16/18, 13:38 Completed build in 10m 03s on Tue, 16 Jan, 02:38 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18367

  16. TYPO3com voted on patch set 6 V +1 01/16/18, 13:42 Completed build in 06m 59s on Tue, 16 Jan, 02:42 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18369

  17. Jörg Bösche voted on patch set 6 CR +1 01/16/18, 13:50

  18. Reiner Teubner rebased onto patch set 7 01/16/18, 14:01

  19. TYPO3com voted on patch set 7 V +1 01/16/18, 14:11 Completed build in 09m 58s on Tue, 16 Jan, 03:11 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18372

  20. Reiner Teubner commented on patch set 7 01/17/18, 08:36

    Reduce the VH to just return a uri (html stuff removed). Add an example and remove [Feature] in rst file.
  21. Christian Kuhn commented on patch set 7 CR -1 01/17/18, 13:17

    can imho be solved with ModuleLinkViewHelper already.
  22. Reiner Teubner abandoned the change 01/17/18, 16:57

    Concept does not work out. We go back to the drawing board.