Review main Merged

55370[BUGFIX] Improve exception output for ImageService

Georg Ringer CR +2 V +2 Easy +2 −1 updated 01/17/18, 10:05

Commit message

Avoid spamming the log in PHP 7.2 due to get_class(null) if fetching the
image in ImageService->getImage() fails.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Jörg Bösche +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Mattia D +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1924

  1. Georg Ringer uploaded patch set 1 01/16/18, 10:28

  2. TYPO3com voted on patch set 1 V +1 01/16/18, 10:35 Completed build in 06m 54s on Tue, 16 Jan, 11:35 AM Test Summary: 30057 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18352

  3. Oliver Klee voted on patch set 1 CR +1 01/16/18, 11:07

  4. Stephan Großberndt voted on patch set 1 CR -1 01/16/18, 12:21

  5. Stephan Großberndt commented on patch set 2 01/16/18, 12:23

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 01/16/18, 12:29 Completed build in 06m 43s on Tue, 16 Jan, 01:29 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18355

  7. Andreas Kienast commented on patch set 2 01/16/18, 12:58

    ImageService.php:130 Unresolved

    IMO we don't need that check.
  8. Stephan Großberndt commented on patch set 3 01/16/18, 13:00

    Published edit on patch set 2.
  9. Stephan Großberndt updated the commit message in patch set 4 01/16/18, 13:07

  10. Stephan Großberndt voted on patch set 4 CR +1 01/16/18, 13:07

  11. Stephan Großberndt updated the commit message in patch set 5 01/16/18, 13:08

  12. Stephan Großberndt voted on patch set 5 CR +1 01/16/18, 13:08

  13. TYPO3com voted on patch set 3 V +1 01/16/18, 13:09 Completed build in 08m 43s on Tue, 16 Jan, 02:09 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18356

  14. TYPO3com voted on patch set 4 V +1 01/16/18, 13:18 Completed build in 10m 30s on Tue, 16 Jan, 02:18 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18360

  15. Andreas Kienast voted on patch set 5 CR +1 01/16/18, 13:18

  16. TYPO3com voted on patch set 5 V +1 01/16/18, 13:23 Completed build in 14m 51s on Tue, 16 Jan, 02:23 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18361

  17. Benni Mack voted on patch set 5 V +1 CR +2 01/16/18, 13:23

  18. Wouter Wolters voted on patch set 5 CR +1 01/16/18, 13:38

  19. Mattia D commented on patch set 5 V +1 01/16/18, 13:42

    Works on my affected site.
  20. Stephan Großberndt commented on patch set 5 01/16/18, 13:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4af1a35c116a819d9e7bd463cbcd66fa5f886ae8
  21. Jörg Bösche voted on patch set 5 CR +1 01/16/18, 13:51

  22. Oliver Klee voted on patch set 5 CR +1 01/16/18, 14:24

  23. Benni Mack voted on patch set 5 V +2 01/17/18, 10:05

  24. Benni Mack merged patch set 6 01/17/18, 10:05