Review main Merged

55371[BUGFIX] Adjust response usage for `file/exists` route

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 01/16/18, 13:20

Commit message

With #83267 a JSON response object was introduced. The patch has the side
effect that any response is now an array but some usages in JavaScript
were not adjusted.

This patch does two things:

- `FileController::fileExistsInFolderAction()` does now either return an
  array for falsy results OR the file object.
- The JavaScript code is adjusted to check for a valid file object by
  requiring the `uid` property instead.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Frank Nägler +1
    • Frans Saris +1
  • Verified V +2
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 910

  1. Andreas Kienast uploaded patch set 1 01/16/18, 11:21

  2. TYPO3com voted on patch set 1 V +1 01/16/18, 11:28 Completed build in 06m 53s on Tue, 16 Jan, 12:28 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18354

  3. Frank Nägler voted on patch set 1 CR +1 01/16/18, 11:41

  4. Frans Saris voted on patch set 1 CR +1 01/16/18, 11:43

  5. Frank Nägler voted on patch set 1 V +1 01/16/18, 11:45

  6. Markus Klein voted on patch set 1 CR +1 01/16/18, 12:08

  7. Wouter Wolters voted on patch set 1 CR +1 01/16/18, 12:18

  8. Stefan Neufeind voted on patch set 1 CR +1 01/16/18, 12:29

  9. Benni Mack voted on patch set 1 V +2 CR +2 01/16/18, 13:20

  10. Benni Mack merged patch set 2 01/16/18, 13:20