Review main Abandoned

55372[BUGFIX] Fix logical error in function getSubpagesForPages within PageRepository Class

David Otto CR 0 V 0 Easy +1 −1 updated 01/16/18, 15:10

Commit message

getSubpagesForPages does not use constraints defined for for the subpages in question on checking wether a shortcut target is valid.

Before this fix the function getSubpagesForPages used the constaints given to filter the resulting subpages to also check if the target of a shortcut is vaild. The validity of a shortcut target (as the comment line above the function sall says: "If shortcut, look up if the target exists and is currently visible") should only depend on its existence and visibilty and not any other constraints used to filter the result of getSubpagesOfPages (e.g. a shortcut itself)

To test this create a shortcut to a page (visible in menu), activate the 'hidden in menu'-option for the page itself and use it in a generated menu.
* before: the shortcut would not be displayed as part of the menu
* after: the shortcut will now be displayed corrertly as part of the menu

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 45

  1. David Otto uploaded patch set 1 01/16/18, 13:13

  2. Mathias Brodala commented on patch set 1 CR -1 01/16/18, 13:16

    This needs a ticket, I also recommend to move most of the commit description to the ticket.
  3. TYPO3com voted on patch set 1 V +1 01/16/18, 13:24 Completed build in 10m 30s on Tue, 16 Jan, 02:24 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18363

  4. Oliver Klee commented on patch set 1 01/16/18, 14:29

    Can we also cover this with a test?
  5. David Otto abandoned the change 01/16/18, 15:10

    New version with attached Issue and better formatting (see: https://review.typo3.org/#/c/55377/)