Review TYPO3_8-7 Abandoned

55374[BUGFIX] Fix logical error in function getSubpagesForPages in PageRepository

David Otto CR 0 V 0 Easy +1 −1 updated 01/16/18, 15:10

Commit message

getSubpagesForPages does not use constraints defined for for the subpages in question on checking wether a shortcut target is valid.

Before this fix the function getSubpagesForPages used the constaints given to filter the resulting subpages to also check if the target of a shortcut is vaild. The validity of a shortcut target (as the comment line above the function sall says: "If shortcut, look up if the target exists and is currently visible") should only depend on its existence and visibilty and not any other constraints used to filter the result of getSubpagesOfPages (e.g. a shortcut itself)

To test this create a shortcut to a page (visible in menu), activate the 'hidden in menu'-option for the page itself and use it in a generated menu.
* before: the shortcut would not be displayed as part of the menu
* after: the shortcut will now be displayed corrertly as part of the menu

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 23

  1. David Otto uploaded patch set 1 01/16/18, 13:19

  2. TYPO3com voted on patch set 1 V +1 01/16/18, 13:35 Completed build in 16m 32s on Tue, 16 Jan, 02:35 PM Test Summary: 57833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1660

  3. David Otto abandoned the change 01/16/18, 15:10

    New version with attached Issue and better formatting (see: https://review.typo3.org/#/c/55378/)