Review TYPO3_8-7 Merged

55375[BUGFIX] Improve exception output for ImageService

Stephan Großberndt CR +2 V +2 Easy +2 −1 updated 01/17/18, 10:05

Commit message

Avoid spamming the log in PHP 7.2 due to get_class(null) if fetching the
image in ImageService->getImage() fails.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Stephan Großberndt commented on patch set 1 01/16/18, 13:48

    Cherry Picked from branch master.
  2. Stephan Großberndt commented on patch set 1 01/16/18, 13:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 618fcc08ff8ae699895304694e5af86e44f162b9
  3. TYPO3com voted on patch set 1 V +1 01/16/18, 13:56 Completed build in 08m 26s on Tue, 16 Jan, 02:57 PM Test Summary: 57833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1661

  4. Oliver Klee voted on patch set 1 CR +1 01/16/18, 14:25

  5. Benni Mack voted on patch set 1 V +2 CR +2 01/17/18, 10:05

  6. Benni Mack merged patch set 2 01/17/18, 10:05