Review TYPO3_7-6 Merged

55376[BUGFIX] Improve exception output for ImageService

Stephan Großberndt CR +2 V +2 Easy +2 −1 updated 01/17/18, 10:05

Commit message

Avoid spamming the log in PHP 7.2 due to get_class(null) if fetching the
image in ImageService->getImage() fails.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Stephan Großberndt commented on patch set 1 01/16/18, 13:48

    Cherry Picked from branch TYPO3_8-7.
  2. TYPO3com voted on patch set 1 V +1 01/16/18, 13:54 Completed build in 05m 23s on Tue, 16 Jan, 02:54 PM Test Summary: 49024 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1324

  3. Oliver Klee voted on patch set 1 CR +1 01/16/18, 14:25

  4. Benni Mack voted on patch set 1 V +2 CR +2 01/17/18, 10:05

  5. Benni Mack merged patch set 2 01/17/18, 10:05