Review main Merged

55381[TASK] impexp: Remove 'max number of records' restriction

Christian Kuhn CR +2 V +2 Normal +91 −36 updated 01/17/18, 12:49

Commit message

The 'export' module has a restriction to limit the number
of exported records. The patch removes this from the
interface:
* The default limit is arbitrary, removing that limit
  declutters the interface a little bit
* Users probably always did just set this to some number
  high enough to export everything they wanted
* It was not clear what exactly is counted. At least it
  was not the total number of exported records ...
* The error and flash messages were unclear and sometimes
  not shown at all
* The limit could lead to data integrity issues in the
  export file, for example if a page links to some other
  page that is not exported
* Presets that increased the limit still work
* To prevent a breaking patch, the affected PHP method
  arguments deprecate some arguments instead of fully
  removing them in v9

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Reiner Teubner +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 68

  1. Christian Kuhn uploaded patch set 1 01/17/18, 12:00

  2. Christian Kuhn uploaded patch set 2 01/17/18, 12:03

  3. TYPO3com voted on patch set 1 V -1 01/17/18, 12:09 Completed build in 08m 58s on Wed, 17 Jan, 01:09 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18384

  4. TYPO3com voted on patch set 2 V +1 01/17/18, 12:10 Completed build in 06m 39s on Wed, 17 Jan, 01:10 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18385

  5. Frank Nägler voted on patch set 2 V +1 CR +1 01/17/18, 12:41

  6. Reiner Teubner voted on patch set 2 V +1 CR +1 01/17/18, 12:47

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 01/17/18, 12:49

  8. Christian Kuhn merged patch set 3 01/17/18, 12:49