Review main Merged

55386[TASK] impexp: Streamline position and layout of CSH

Frank Nägler CR +2 V +2 Normal +45 −51 updated 01/18/18, 14:01

Commit message

This patch streamlines the position and layout for the content help buttons
in ext:impexp. Like already done in FormEngine, the CSH now wraps
around field labels.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1318

  1. Frank Nägler uploaded patch set 1 01/17/18, 18:54

  2. Frank Nägler updated the commit message in patch set 2 01/17/18, 18:57

  3. TYPO3com voted on patch set 1 V +1 01/17/18, 19:01 Completed build in 07m 08s on Wed, 17 Jan, 08:01 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18400

  4. TYPO3com voted on patch set 2 V +1 01/17/18, 19:04 Completed build in 06m 33s on Wed, 17 Jan, 08:04 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18401

  5. Frank Nägler commented on patch set 2 CR -1 01/17/18, 19:53

    on it
  6. Frank Nägler uploaded patch set 3 01/17/18, 20:26

  7. Christian Kuhn updated the commit message in patch set 4 01/17/18, 20:32

  8. TYPO3com voted on patch set 3 V +1 01/17/18, 20:32 Completed build in 06m 25s on Wed, 17 Jan, 09:32 PM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18405

  9. TYPO3com voted on patch set 4 V +1 01/17/18, 20:39 Completed build in 06m 32s on Wed, 17 Jan, 09:39 PM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18406

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 01/17/18, 20:40

  11. Christian Kuhn commented on patch set 4 V 0 CR 0 01/17/18, 20:56

    this seems to give funny result on the labels above the select boxes. at least on second click, did not really find a pattern yet. maybe some other js doing something.
  12. Anja Leichsenring commented on patch set 4 V -1 01/17/18, 20:58

    does not work with the select boxes. Instead the help popup comming into view, the select box is focused. I can see some reaction using the inspection window, but the desired result is not presented. Further down the view, help text on 'exclude elements' comes up.
  13. Frank Nägler uploaded patch set 5 01/17/18, 23:01

  14. TYPO3com voted on patch set 5 V +1 01/17/18, 23:06 Completed build in 05m 26s on Thu, 18 Jan, 12:06 AM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18413

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 01/18/18, 13:13

  16. Anja Leichsenring voted on patch set 5 V +1 CR +1 01/18/18, 13:23

  17. Christian Kuhn voted on patch set 5 V +2 CR +2 01/18/18, 14:01

  18. Christian Kuhn merged patch set 6 01/18/18, 14:01