55386[TASK] impexp: Streamline position and layout of CSH
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php+14 −0
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.html+5 −7
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+17 −26
- typo3/sysext/impexp/Resources/Private/Partials/Export/Save.html+3 −6
- typo3/sysext/impexp/Resources/Private/Partials/Import/Import.html+5 −10
- typo3/sysext/impexp/Resources/Private/Partials/Import/Upload.html+1 −2
Review log 1318
-
Frank Nägler uploaded patch set 1 01/17/18, 18:54
-
Frank Nägler updated the commit message in patch set 2 01/17/18, 18:57
-
TYPO3com voted on patch set 1 V +1 01/17/18, 19:01 Completed build in 07m 08s on Wed, 17 Jan, 08:01 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18400
-
TYPO3com voted on patch set 2 V +1 01/17/18, 19:04 Completed build in 06m 33s on Wed, 17 Jan, 08:04 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18401
-
Frank Nägler commented on patch set 2 CR -1 01/17/18, 19:53
on it -
Frank Nägler uploaded patch set 3 01/17/18, 20:26
-
Christian Kuhn updated the commit message in patch set 4 01/17/18, 20:32
-
TYPO3com voted on patch set 3 V +1 01/17/18, 20:32 Completed build in 06m 25s on Wed, 17 Jan, 09:32 PM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18405
-
TYPO3com voted on patch set 4 V +1 01/17/18, 20:39 Completed build in 06m 32s on Wed, 17 Jan, 09:39 PM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18406
-
Christian Kuhn voted on patch set 4 V +1 CR +1 01/17/18, 20:40
-
Christian Kuhn commented on patch set 4 V 0 CR 0 01/17/18, 20:56
this seems to give funny result on the labels above the select boxes. at least on second click, did not really find a pattern yet. maybe some other js doing something. -
Anja Leichsenring commented on patch set 4 V -1 01/17/18, 20:58
does not work with the select boxes. Instead the help popup comming into view, the select box is focused. I can see some reaction using the inspection window, but the desired result is not presented. Further down the view, help text on 'exclude elements' comes up. -
Frank Nägler uploaded patch set 5 01/17/18, 23:01
-
TYPO3com voted on patch set 5 V +1 01/17/18, 23:06 Completed build in 05m 26s on Thu, 18 Jan, 12:06 AM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18413
-
Christian Kuhn voted on patch set 5 V +1 CR +1 01/18/18, 13:13
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 01/18/18, 13:23
-
Christian Kuhn voted on patch set 5 V +2 CR +2 01/18/18, 14:01
-
Christian Kuhn merged patch set 6 01/18/18, 14:01