55411[TASK] Minor annotation and sanitation improvements
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
- Frank Nägler +1
- Reiner Teubner +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Backend/ToolbarItems/HelpToolbarItem.php+2 −1
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+4 −6
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php3+2 −1
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+3 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/core/Classes/Compatibility/PublicPropertyDeprecationTrait.php+4 −0
- typo3/sysext/core/Classes/Log/Logger.php+0 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+3 −3
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+12 −5
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+1 −1
- typo3/sysext/rsaauth/Classes/Report/RsauthStatus.php+1 −1
Review log 911
-
Christian Kuhn uploaded patch set 1 01/19/18, 10:16
-
Christian Kuhn uploaded patch set 2 01/19/18, 10:20
-
Mathias Brodala commented on patch set 1 01/19/18, 10:21
ElementInformationController.php:172Totally makes sense but I hope this doesn't break something. -
TYPO3com voted on patch set 1 V +1 01/19/18, 10:23 Completed build in 06m 56s on Fri, 19 Jan, 11:23 AM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18452
-
TYPO3com voted on patch set 2 V +1 01/19/18, 10:29 Completed build in 09m 01s on Fri, 19 Jan, 11:29 AM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18453
-
Oliver Klee voted on patch set 2 CR +1 01/19/18, 14:35
-
Reiner Teubner voted on patch set 2 CR +1 01/19/18, 14:38
-
Christian Kuhn commented on patch set 1 01/19/18, 14:42
ElementInformationController.php:172Replycan't break something, since that would otherwise fatal with $this->fileObject->checkActionPermission('read'); already. -
Frank Nägler voted on patch set 2 V +1 CR +1 01/19/18, 14:44
-
Christian Kuhn voted on patch set 2 V +2 CR +2 01/19/18, 14:44
-
Christian Kuhn merged patch set 3 01/19/18, 14:44
ElementInformationController.php:92