Review main Merged

55411[TASK] Minor annotation and sanitation improvements

Christian Kuhn CR +2 V +2 Normal +34 −22 updated 01/19/18, 14:44

Commit message

Various changes throughout the system improving
method annotations here and there or sanitizing
code a bit better.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Frank Nägler +1
    • Reiner Teubner +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 911

  1. Christian Kuhn uploaded patch set 1 01/19/18, 10:16

  2. Christian Kuhn uploaded patch set 2 01/19/18, 10:20

  3. Mathias Brodala commented on patch set 1 01/19/18, 10:21

    ElementInformationController.php:92

    This should be \TYPO3\CMS\Core\Resource\ResourceInterface instead

    ElementInformationController.php:172

    Totally makes sense but I hope this doesn't break something.
  4. TYPO3com voted on patch set 1 V +1 01/19/18, 10:23 Completed build in 06m 56s on Fri, 19 Jan, 11:23 AM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18452

  5. TYPO3com voted on patch set 2 V +1 01/19/18, 10:29 Completed build in 09m 01s on Fri, 19 Jan, 11:29 AM Test Summary: 30181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18453

  6. Oliver Klee voted on patch set 2 CR +1 01/19/18, 14:35

  7. Reiner Teubner voted on patch set 2 CR +1 01/19/18, 14:38

  8. Christian Kuhn commented on patch set 1 01/19/18, 14:42

    ElementInformationController.php:172 Reply

    can't break something, since that would otherwise fatal with $this->fileObject->checkActionPermission('read'); already.
  9. Frank Nägler voted on patch set 2 V +1 CR +1 01/19/18, 14:44

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 01/19/18, 14:44

  11. Christian Kuhn merged patch set 3 01/19/18, 14:44