55412[TASK] Specific exception in ArrayUtility::getValueByPath()
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
- Mathias Brodala +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 2
Files 16
- typo3/sysext/core/Classes/Utility/Exception/MissingArrayPathException.php2new+26 −0
- typo3/sysext/core/Classes/Utility/ArrayUtility.php2+8 −5
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php2+15 −6
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+5 −4
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+3 −2
- typo3/sysext/form/Classes/Domain/Finishers/FinisherVariableProvider.php+2 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+2 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormState.php+2 −1
- typo3/sysext/form/Classes/Hooks/DataStructureIdentifierHook.php+3 −2
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+7 −6
- typo3/sysext/form/Classes/Service/TranslationService.php+5 −4
- typo3/sysext/install/Classes/Configuration/AbstractPreset.php+2 −1
- typo3/sysext/install/Classes/Controller/LayoutController.php+8 −2
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+58 −49
- typo3/sysext/install/Classes/Updates/WizardDoneToRegistry.php+3 −2
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+14 −42
Review log 1826
Show 1 earlier messages
-
Christian Kuhn uploaded patch set 1 01/19/18, 13:45
-
Christian Kuhn updated the commit message in patch set 2 01/19/18, 13:48
-
Mathias Brodala commented on patch set 1 01/19/18, 13:49
-
TYPO3com voted on patch set 1 V -1 01/19/18, 13:52 Completed build in 07m 01s on Fri, 19 Jan, 02:52 PM Test Summary: 9 of 30351 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18460
-
TYPO3com voted on patch set 2 V -1 01/19/18, 13:55 Completed build in 06m 26s on Fri, 19 Jan, 02:55 PM Test Summary: 9 of 30351 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18461
-
Christian Kuhn uploaded patch set 3 01/19/18, 13:55
-
TYPO3com voted on patch set 3 V -1 01/19/18, 14:03 Completed build in 08m 06s on Fri, 19 Jan, 03:03 PM Test Summary: 9 of 30351 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18462
-
Christian Kuhn uploaded patch set 4 01/19/18, 14:26
-
Christian Kuhn uploaded patch set 5 01/19/18, 14:28
-
Oliver Klee commented on patch set 5 01/19/18, 14:32
MissingArrayPathException.php:2strict, please (so that all new files are strict by default)ArrayUtilityTest.php:336string type hinting, please -
TYPO3com voted on patch set 4 V -1 01/19/18, 14:33 Completed build in 06m 56s on Fri, 19 Jan, 03:33 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18463
-
TYPO3com voted on patch set 5 V +1 01/19/18, 14:36 Completed build in 08m 24s on Fri, 19 Jan, 03:36 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18464
-
Christian Kuhn uploaded patch set 6 01/19/18, 14:38
-
Mathias Brodala commented on patch set 5 01/19/18, 14:40
ArrayUtility.php:200We should mention the path here (implode()'d with $delimiter) -
TYPO3com voted on patch set 6 V +1 01/19/18, 14:45 Completed build in 06m 55s on Fri, 19 Jan, 03:45 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18465
-
Christian Kuhn uploaded patch set 7 01/19/18, 14:46
-
Christian Kuhn commented on patch set 5 01/19/18, 14:47
ArrayUtility.php:200ReplyDoneMissingArrayPathException.php:2ReplyDoneArrayUtilityTest.php:336ReplyDone -
Frank Nägler voted on patch set 7 V +1 CR +1 01/19/18, 14:55
-
TYPO3com voted on patch set 7 V +1 01/19/18, 14:55 Completed build in 09m 02s on Fri, 19 Jan, 03:55 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18468
-
Christian Kuhn uploaded patch set 8 01/19/18, 14:58
-
Frank Nägler voted on patch set 8 V +1 CR +1 01/19/18, 15:01
-
Mathias Brodala voted on patch set 8 CR +1 01/19/18, 15:02
-
TYPO3com voted on patch set 8 V +1 01/19/18, 15:05 Completed build in 06m 33s on Fri, 19 Jan, 04:05 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18469
-
Mathias Brodala commented on patch set 8 V +1 01/19/18, 15:07
I believe in Bamboo. -
Christian Kuhn voted on patch set 8 V +2 CR +2 01/19/18, 15:08
-
Christian Kuhn merged patch set 9 01/19/18, 15:08
ArrayUtilityGetValueByPathDoesNotExistException.php:23