Review main Merged

55413[BUGFIX] Extension config: Write LocalConfiguration only if needed

Christian Kuhn CR +2 V +2 Easy +4 −1 updated 01/19/18, 17:31

Commit message

The extension configuration is currently written by the
install tool silent updater each time the install tool
is entered, even if no configuration detail changed.
This is unfortunate on systems with read-only LocalConfiguration
since the install tool then throws an early fatal.
Prevent that write operation in case nothing changed.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Anja Leichsenring +1
  • Verified V +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/19/18, 16:38

  2. Christian Kuhn updated the commit message in patch set 2 01/19/18, 16:40

  3. TYPO3com voted on patch set 2 V +1 01/19/18, 16:46 Completed build in 06m 38s on Fri, 19 Jan, 05:46 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18473

  4. TYPO3com voted on patch set 1 V +1 01/19/18, 16:47 Completed build in 08m 50s on Fri, 19 Jan, 05:47 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18472

  5. Christian Kuhn commented on patch set 2 01/19/18, 17:01

    easy to reproduce: * Call install tool standalone (/typo3/install.php) * Create ENABLE_INSTALL_TOOL * Log in, see standalone is rendered (this makes sure LocalConfiguration is up-to-date "now") * chmod 440 typo3conf/LocalConfiguration.php (make it read-only) * reload install tool -> boom * apply patch -> install tool works
  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/19/18, 17:08

  7. Frank Nägler voted on patch set 2 CR +1 01/19/18, 17:16

  8. Frank Nägler voted on patch set 2 V +2 CR +2 01/19/18, 17:30

  9. Frank Nägler merged patch set 3 01/19/18, 17:31