Review main Merged

55415[TASK] Add getter for TemplateService->rootId

Benni Mack CR +2 V +2 Easy +11 −1 updated 01/20/18, 19:23

Commit message

The rootID holds the page ID where the root sys_template
record was found.

As this is crucial for some hooks this property
should be publically available but is marked as
deprecated during v9 development, a getter is added
to provide a public API.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 01/20/18, 13:34

  2. TYPO3com voted on patch set 1 V +1 01/20/18, 13:41 Completed build in 06m 27s on Sat, 20 Jan, 02:41 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18484

  3. Oliver Klee commented on patch set 1 01/20/18, 14:33

    TemplateService.php:1455

    return type hint, please
  4. Benni Mack uploaded patch set 2 01/20/18, 15:27

  5. Oliver Klee voted on patch set 2 CR +1 01/20/18, 15:30

  6. TYPO3com voted on patch set 2 V +1 01/20/18, 15:34 Completed build in 06m 32s on Sat, 20 Jan, 04:34 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18491

  7. Georg Ringer commented on patch set 2 V +2 CR +2 01/20/18, 19:23

    merged as lowbrainer
  8. Georg Ringer merged patch set 3 01/20/18, 19:23