Review main Merged

55422Revert "[FEATURE] EXT:form - introduce YAML "imports""

Helmut Hummel CR +2 V +2 Nightmare +2392 −3427 updated 01/30/18, 12:04

Commit message

While the intended feature is great (having the possiblity
to extract and re-use parts of the form definition),
implementation wise it needs some rework.

To be able to release 9.1 as stable as possible,
we now revert this implementation for now
and bring it in for 9.2 again.

This reverts commit a52a99220ca24251186ea88d11b3db43436a8156.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 41

Show 21 more files

Review log 1216

  1. Helmut Hummel uploaded patch set 1 01/21/18, 17:40

  2. TYPO3com voted on patch set 1 V -1 01/21/18, 17:40 Completed build in 09s on Sun, 21 Jan, 06:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18502

  3. Ralf Zimmermann commented on patch set 1 CR -1 01/23/18, 09:58

    @helmut please see review:55430
  4. Helmut Hummel uploaded patch set 2 01/28/18, 21:36

  5. TYPO3com voted on patch set 2 V -1 01/28/18, 21:42 Completed build in 06m 11s on Sun, 28 Jan, 10:42 PM Test Summary: 3 of 30512 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18687

  6. Oliver Hader commented on patch set 2 01/28/18, 22:54

    Thanks Helmut. I'm +1 on reverting for 9.1 and re-introduce the feature again for 9.2 with enhancements.
  7. Ralf Zimmermann uploaded patch set 3 01/29/18, 13:26

  8. TYPO3com voted on patch set 3 V +1 01/29/18, 13:32 Completed build in 06m 15s on Mon, 29 Jan, 02:32 PM Test Summary: 30357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18700

  9. Markus Klein commented on patch set 3 01/29/18, 20:31

    Releases: master? Do we have a dedicated ticket for the revert? Resolves: ?
  10. Frank Nägler commented on patch set 3 01/30/18, 07:57

  11. Oliver Hader updated the commit message in patch set 4 01/30/18, 09:01

  12. Oliver Hader voted on patch set 4 CR +1 01/30/18, 09:06

  13. TYPO3com voted on patch set 4 V +1 01/30/18, 09:06 Completed build in 05m 24s on Tue, 30 Jan, 10:06 AM Test Summary: 30354 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18722

  14. Oliver Hader voted on patch set 4 V +1 01/30/18, 10:38

  15. Oliver Hader voted on patch set 4 V +2 CR +2 01/30/18, 12:04

  16. Oliver Hader merged patch set 5 01/30/18, 12:04