55422Revert "[FEATURE] EXT:form - introduce YAML "imports""
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
- TYPO3com +1 CI
Issues 1
Files 41
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader/Configuration.phpdeleted+0 −114
- typo3/sysext/core/Classes/Configuration/Loader/FalYamlFileLoader.phpdeleted+0 −79
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php+16 −53
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoaderInterface.phpdeleted+0 −37
- typo3/sysext/core/Classes/Configuration/Writer/Exception/FileWriteException.phpdeleted+0 −22
- typo3/sysext/core/Classes/Configuration/Writer/YamlFileWriter.phpdeleted+0 −64
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-82089-ExtFormYamlConfigurationsTyposcriptOption.rstdeleted+0 −112
- typo3/sysext/core/Documentation/Changelog/master/Feature-82089-ExtFormSupportsYamlImports.rstdeleted+0 −165
- typo3/sysext/core/Tests/Unit/Configuration/Loader/YamlFileLoaderTest.php+0 −13
- typo3/sysext/form/Classes/Controller/FormEditorController.php+10 −247
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −5
- typo3/sysext/form/Classes/Controller/FormManagerController.php+4 −12
- typo3/sysext/form/Classes/Domain/Exception/FormDefinitionNotValidException.phpdeleted+0 −25
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+0 −36
- typo3/sysext/form/Classes/Mvc/Configuration/Exception/NoConfigurationFoundException.phpdeleted+0 −24
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManager.php+25 −83
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.phpnew+185 −0
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+19 −13
- typo3/sysext/form/Classes/Property/TypeConverter/FormDefinitionArrayConverter.php+6 −3
Show 21 more files
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −1
- typo3/sysext/form/Configuration/TypoScript/setup.txt+5 −2
- typo3/sysext/form/Configuration/Yaml/BaseSetup.yamlnew+455 −0
- typo3/sysext/form/Configuration/Yaml/FormEditorSetup.yamlnew+1410 −0
- typo3/sysext/form/Configuration/Yaml/FormEngineSetup.yamlnew+131 −0
- typo3/sysext/form/Configuration/Yaml/FormSetup.yamldeleted+0 −1747
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/EmailSelectEditor.htmldeleted+0 −67
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/File1.yamldeleted+0 −21
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/File2.yamldeleted+0 −27
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/File3.yamldeleted+0 −9
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/File4.yamldeleted+0 −6
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/Header.yamlrenamed+0 −0
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/ConfigurationManagerTest.phpdeleted+0 −220
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/YamlSourceTest.phpnew+106 −0
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File1.yamldeleted+0 −21
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File2.yamldeleted+0 −27
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File3.yamldeleted+0 −9
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/Fixtures/File4.yamldeleted+0 −6
- typo3/sysext/form/Tests/UnitDeprecated/Mvc/Configuration/ConfigurationManagerTest.phpdeleted+0 −142
- typo3/sysext/form/ext_localconf.php+3 −14
- typo3/sysext/form/ext_typoscript_setup.txtnew+14 −0
Review log 1216
-
Helmut Hummel uploaded patch set 1 01/21/18, 17:40
-
TYPO3com voted on patch set 1 V -1 01/21/18, 17:40 Completed build in 09s on Sun, 21 Jan, 06:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18502
-
Ralf Zimmermann commented on patch set 1 CR -1 01/23/18, 09:58
@helmut please see review:55430 -
Helmut Hummel uploaded patch set 2 01/28/18, 21:36
-
TYPO3com voted on patch set 2 V -1 01/28/18, 21:42 Completed build in 06m 11s on Sun, 28 Jan, 10:42 PM Test Summary: 3 of 30512 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18687
-
Oliver Hader commented on patch set 2 01/28/18, 22:54
Thanks Helmut. I'm +1 on reverting for 9.1 and re-introduce the feature again for 9.2 with enhancements. -
Ralf Zimmermann uploaded patch set 3 01/29/18, 13:26
-
TYPO3com voted on patch set 3 V +1 01/29/18, 13:32 Completed build in 06m 15s on Mon, 29 Jan, 02:32 PM Test Summary: 30357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18700
-
Markus Klein commented on patch set 3 01/29/18, 20:31
Releases: master? Do we have a dedicated ticket for the revert? Resolves: ? -
Frank Nägler commented on patch set 3 01/30/18, 07:57
Please see the revert workflow: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/GeneralTopics/LifeOfAPatch.html#reverting-patches -
Oliver Hader updated the commit message in patch set 4 01/30/18, 09:01
-
Oliver Hader voted on patch set 4 CR +1 01/30/18, 09:06
-
TYPO3com voted on patch set 4 V +1 01/30/18, 09:06 Completed build in 05m 24s on Tue, 30 Jan, 10:06 AM Test Summary: 30354 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18722
-
Oliver Hader voted on patch set 4 V +1 01/30/18, 10:38
-
Oliver Hader voted on patch set 4 V +2 CR +2 01/30/18, 12:04
-
Oliver Hader merged patch set 5 01/30/18, 12:04