Review main Merged

55424[TASK] Specific exception in ArrayUtility::removeByPath()

Christian Kuhn CR +2 V +2 Easy +20 −2 updated 01/23/18, 17:05

Commit message

Similar to getValueByPath(), removeByPath() now throws
a specific exception if the path to remove does not
exist in given array to avoid catching global \RuntimeException'
in consuming code.
The same "MissingArrayPathException" is used here since
both cases have identical semantic.

Review

  • Code review CR +2
    • Susi Moog +2
    • Reiner Teubner +1
    • Helmut Hummel +1
  • Verified V +2
    • Susi Moog +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 810

  1. Christian Kuhn uploaded patch set 1 01/22/18, 13:42

  2. Christian Kuhn updated the commit message in patch set 2 01/22/18, 13:43

  3. TYPO3com voted on patch set 1 V +1 01/22/18, 13:51 Completed build in 09m 17s on Mon, 22 Jan, 02:52 PM Test Summary: 30196 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18514

  4. TYPO3com voted on patch set 2 V +1 01/22/18, 13:52 Completed build in 09m 01s on Mon, 22 Jan, 02:52 PM Test Summary: 30196 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18515

  5. Reiner Teubner voted on patch set 2 CR +1 01/22/18, 14:27

  6. Nicole Hummel commented on patch set 2 01/22/18, 14:37

    ArrayUtilityTest.php:786

    Still some RuntimeException expectation?!
  7. Christian Kuhn commented on patch set 2 01/22/18, 21:05

    ArrayUtilityTest.php:786 Reply

    this is kept to verify patch is b/w compat.
  8. Helmut Hummel voted on patch set 2 V +1 CR +1 01/23/18, 14:16

  9. Susi Moog voted on patch set 2 V +2 CR +2 01/23/18, 17:05

  10. Susi Moog merged patch set 3 01/23/18, 17:05