55427[!!!][TASK] Remove sys_domain redirect functionality
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Christian Kuhn +1
- Jörg Bösche +1
-
Verified V +2
- Susi Moog +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+0 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+0 −4
- typo3/sysext/backend/Tests/Functional/Utility/Fixtures/sys_domain.xml+0 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-83638-RedirectFunctionalityMovedFromSys_domainToRedirectsModule.rstnew+38 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −6
- typo3/sysext/frontend/Classes/Page/PageRepository.php+1 −23
- typo3/sysext/frontend/Configuration/TCA/sys_domain.php+3 −41
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+0 −21
- typo3/sysext/frontend/Tests/Functional/Tca/DomainVisibleFieldsTest.php+1 −4
- typo3/sysext/frontend/ext_tables.sql+1 −4
- typo3/sysext/install/Classes/Updates/RedirectsExtensionUpdate.php5new+207 −0
- typo3/sysext/install/ext_localconf.php+2 −0
Review log 1216
-
Benni Mack uploaded patch set 1 01/22/18, 15:43
-
TYPO3com voted on patch set 1 V +1 01/22/18, 15:53 Completed build in 09m 13s on Mon, 22 Jan, 04:53 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18520
-
Oliver Klee commented on patch set 1 01/22/18, 16:06
RedirectsExtensionUpdate.php:71Return type hinting, please. -
Susi Moog commented on patch set 2 01/22/18, 16:51
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 01/22/18, 16:58 Completed build in 07m 07s on Mon, 22 Jan, 05:58 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18521
-
Georg Ringer commented on patch set 2 CR -1 01/23/18, 06:58
RedirectsExtensionUpdate.php:74Unresolvedthere is no return value of method installExtension!RedirectsExtensionUpdate.php:74there is no return value of method installExtension! -
Susi Moog uploaded patch set 3 01/23/18, 13:22
-
TYPO3com voted on patch set 3 V -1 01/23/18, 13:23 Completed build in 11s on Tue, 23 Jan, 02:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18540
-
Susi Moog uploaded patch set 4 01/23/18, 13:27
-
Susi Moog commented on patch set 4 01/23/18, 13:27
RedirectsExtensionUpdate.php:74ReplyDone -
TYPO3com voted on patch set 4 V +1 01/23/18, 13:32 Completed build in 05m 30s on Tue, 23 Jan, 02:32 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18541
-
Jörg Bösche voted on patch set 4 CR +1 01/23/18, 14:31
-
Christian Kuhn voted on patch set 4 V +1 CR +1 01/23/18, 16:52
-
Susi Moog voted on patch set 4 V +2 CR +2 01/23/18, 16:55
-
Susi Moog merged patch set 5 01/23/18, 16:55
-
Josef Glatz commented on patch set 5 10/14/20, 07:04
Does not work in a most of our projects where we have "redirect domains" like described in https://forge.typo3.org/issues/89578
RedirectsExtensionUpdate.php:46