Review main Merged Breaking

55427[!!!][TASK] Remove sys_domain redirect functionality

Benni Mack CR +2 V +2 Hard +253 −108 updated 10/14/20, 07:04

Commit message

The existing functionality of sys_domain database records that redirect to a
different target has been migrated into the new "redirects" core extension.

An upgrade wizard ensures that old (and even deleted) sys_domain records
with a redirect target (database field "redirectTo") are properly migrated into
the redirects extension.

The following database fields have been dropped:
- sys_domain.redirectTo
- sys_domain.redirectHttpStatusCode
- sys_domain.prepend_params

These values are not evaluated anymore in the TYPO3 Frontend.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1216

  1. Benni Mack uploaded patch set 1 01/22/18, 15:43

  2. TYPO3com voted on patch set 1 V +1 01/22/18, 15:53 Completed build in 09m 13s on Mon, 22 Jan, 04:53 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18520

  3. Oliver Klee commented on patch set 1 01/22/18, 16:06

    RedirectsExtensionUpdate.php:46

    Return type hinting, please.

    RedirectsExtensionUpdate.php:71

    Return type hinting, please.
  4. Susi Moog commented on patch set 2 01/22/18, 16:51

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 01/22/18, 16:58 Completed build in 07m 07s on Mon, 22 Jan, 05:58 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18521

  6. Georg Ringer commented on patch set 2 CR -1 01/23/18, 06:58

    RedirectsExtensionUpdate.php:74 Unresolved

    there is no return value of method installExtension!

    RedirectsExtensionUpdate.php:74

    there is no return value of method installExtension!
  7. Susi Moog uploaded patch set 3 01/23/18, 13:22

  8. TYPO3com voted on patch set 3 V -1 01/23/18, 13:23 Completed build in 11s on Tue, 23 Jan, 02:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18540

  9. Susi Moog uploaded patch set 4 01/23/18, 13:27

  10. Susi Moog commented on patch set 4 01/23/18, 13:27

    RedirectsExtensionUpdate.php:74 Reply

    Done
  11. TYPO3com voted on patch set 4 V +1 01/23/18, 13:32 Completed build in 05m 30s on Tue, 23 Jan, 02:32 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18541

  12. Jörg Bösche voted on patch set 4 CR +1 01/23/18, 14:31

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 01/23/18, 16:52

  14. Susi Moog voted on patch set 4 V +2 CR +2 01/23/18, 16:55

  15. Susi Moog merged patch set 5 01/23/18, 16:55

  16. Josef Glatz commented on patch set 5 10/14/20, 07:04

    Does not work in a most of our projects where we have "redirect domains" like described in https://forge.typo3.org/issues/89578