Review main Merged

55428[BUGFIX] Use correct default value for field data_page_reg1

Georg Ringer CR +2 V +2 Easy +1 −1 updated 01/24/18, 15:29

Commit message

The field data_page_reg1 of table index_phash is defined as integer.
Therefore the default value must be 0 instead of an empty string.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Reiner Teubner +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 01/23/18, 04:24

  2. TYPO3com voted on patch set 1 V +1 01/23/18, 04:32 Completed build in 07m 37s on Tue, 23 Jan, 05:32 AM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18530

  3. Andreas Kienast voted on patch set 1 CR +1 01/23/18, 08:11

  4. Reiner Teubner voted on patch set 1 CR +1 01/23/18, 09:01

  5. Christian Kuhn commented on patch set 1 01/24/18, 15:22

    for the fun part of it: did anyone had a look what that property is good for? thus, +1 to the patch with the backport, but next step is to kick that field / property in master.
  6. Oliver Klee voted on patch set 1 CR +1 01/24/18, 15:24

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 01/24/18, 15:28

  8. Christian Kuhn merged patch set 2 01/24/18, 15:28

  9. Christian Kuhn commented on patch set 2 01/24/18, 15:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8776292ca4f393d51dc441f774a5a14763d61934
  10. Christian Kuhn commented on patch set 2 01/24/18, 15:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f0350ca0c9b8abf0b938a5f8874534f3aa7dad19