Review main Merged

55434[TASK] Improved extension configuration API

Christian Kuhn CR +2 V +2 Hard +527 −457 updated 01/29/18, 23:11

Commit message

The patch implements feedback from the new
ExtensionConfiguration API.
get() now falls back to a parsing of ext_conf_template,
so the parser is moved from the install tool
to the ext:core class. This prevents a chicken-egg
issue in early setup phases.

The move of the synchronize* methods forces a raise
of the testing-framework:

composer require --dev typo3/testing-framework ^2.0.3

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2
    • Helmut Hummel +2
    • Oliver Hader +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2942

Show 1017 earlier messages
  1. Christian Kuhn uploaded patch set 1 01/23/18, 12:43

  2. TYPO3com voted on patch set 1 V -1 01/23/18, 12:45 Completed build in 02m 01s on Tue, 23 Jan, 01:45 PM Test Summary: 2724 of 2865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18538

  3. Christian Kuhn uploaded patch set 2 01/23/18, 13:33

  4. TYPO3com voted on patch set 2 V -1 01/23/18, 13:33 Completed build in 11s on Tue, 23 Jan, 02:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18542

  5. Christian Kuhn uploaded patch set 3 01/23/18, 13:34

  6. TYPO3com voted on patch set 3 V +1 01/23/18, 13:42 Completed build in 08m 02s on Tue, 23 Jan, 02:42 PM Test Summary: 30190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18543

  7. Helmut Hummel commented on patch set 3 01/23/18, 14:22

    InstallUtility.php:164

    I think this line can now be moved to processExtensionSetup again
  8. Christian Kuhn commented on patch set 3 01/24/18, 08:59

    InstallUtility.php:164 Reply

    Done
  9. Christian Kuhn uploaded patch set 4 01/24/18, 09:28

  10. TYPO3com voted on patch set 4 V -1 01/24/18, 09:37 Completed build in 09m 05s on Wed, 24 Jan, 10:37 AM Test Summary: 1 of 30414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18567

  11. TYPO3com commented on patch set 4 01/24/18, 10:20 Completed build in 1h 00m 57s on Wed, 24 Jan, 11:20 AM Test Summary: 1 of 30414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18567

  12. Christian Kuhn commented on patch set 3 01/24/18, 10:20

    InstallUtility.php:164 Reply

    does not work, installing ext:introduction fails if moving that call around - reverting to version of patch set 3 with set 5.
  13. Christian Kuhn uploaded patch set 5 01/24/18, 10:21

  14. TYPO3com voted on patch set 5 V +1 01/24/18, 10:28 Completed build in 06m 21s on Wed, 24 Jan, 11:28 AM Test Summary: 30259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18572

  15. Alexander Opitz commented on patch set 5 01/29/18, 10:40

    ExtensionConfiguration.php:190

    set()?
  16. Alexander Opitz commented on patch set 5 V +1 01/29/18, 11:03

    Tested with installing and configuring TV+ via ExtensionManager
  17. TYPO3com commented on patch set 4 01/29/18, 18:14 Completed build in 9h 47m 20s on Mon, 29 Jan, 07:14 PM Test Summary: 1 of 30414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18567

  1. Helmut Hummel commented on patch set 3 01/29/18, 18:18

    InstallUtility.php:164 Reply

  2. Jigal van Hemert commented on patch set 5 01/29/18, 19:11

    > (1 comment) The failed logs are for patch set 4. Number 5 already has a +1 from bamboo.
  3. Jigal van Hemert commented on patch set 5 01/29/18, 19:16

    > > (1 comment) > > The failed logs are for patch set 4. Number 5 already has a +1 from > bamboo. Sorry, I go completely confused with the numbering and reverting. Ignore this comment please :-)
  4. Helmut Hummel commented on patch set 5 V -1 CR -1 01/29/18, 20:11

    lookig at it
  5. Helmut Hummel commented on patch set 5 01/29/18, 20:25

    ExtensionConfiguration.php:190 Reply

    Done
  6. Helmut Hummel uploaded patch set 6 01/29/18, 20:26

  7. Helmut Hummel commented on patch set 6 01/29/18, 20:27

    since I could not reproduce any failure with moving saveDefaultConfiguration back to its place, I pushed a new version which contains this change also fixed a typo mentioned by alex
  8. TYPO3com voted on patch set 6 V -1 01/29/18, 20:32 Completed build in 06m 18s on Mon, 29 Jan, 09:32 PM Test Summary: 1 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18710

  9. TYPO3com commented on patch set 6 01/29/18, 21:09 Completed build in 49m 56s on Mon, 29 Jan, 10:09 PM Test Summary: 1 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18710

  10. TYPO3com commented on patch set 6 01/29/18, 21:20 Completed build in 1h 44m 02s on Mon, 29 Jan, 10:20 PM Test Summary: 1 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18710

  11. Helmut Hummel uploaded patch set 7 01/29/18, 21:23

  12. Helmut Hummel uploaded patch set 8 01/29/18, 21:24

  13. TYPO3com voted on patch set 7 V +1 01/29/18, 21:32 Completed build in 08m 55s on Mon, 29 Jan, 10:32 PM Test Summary: 30355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18713

  14. TYPO3com voted on patch set 8 V -1 01/29/18, 21:33 Completed build in 08m 49s on Mon, 29 Jan, 10:33 PM Test Summary: 3 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18714

  15. Helmut Hummel uploaded patch set 9 01/29/18, 21:39

  16. Helmut Hummel voted on patch set 9 V +2 CR +2 01/29/18, 21:40

  17. TYPO3com voted on patch set 9 V +1 01/29/18, 21:47 Completed build in 07m 48s on Mon, 29 Jan, 10:47 PM Test Summary: 30355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18715

  18. Susi Moog voted on patch set 9 V +1 CR +1 01/29/18, 21:52

  19. Susi Moog merged patch set 10 01/29/18, 21:52

  20. Markus Klein commented on patch set 9 01/29/18, 21:58

    ExtensionConfiguration.php:45

    built

    ExtensionConfiguration.php:58

    initialize with [] or add null as typehint above

    ExtensionConfiguration.php:200

    can be removed
  21. Oliver Hader commented on patch set 10 01/29/18, 21:58

    I tried to analyze the pgsql issue as well but could not find anything obvious in the code. That also might be a side effect on the testing agents...
  22. Susi Moog commented on patch set 10 01/29/18, 22:00

    > Patch Set 10: > > I tried to analyze the pgsql issue as well but could not find anything obvious in the code. That also might be a side effect on the testing agents... Tested with pgsql locally with and without subfolder installation, both work fine. Discussed with Helmut to have a look at the issue / agents after the release.
  23. Oliver Hader commented on patch set 10 01/29/18, 22:05

    @Susi: Thx @Markus: Could you please create a follow-up if you think these changes are required for the 9.1 release. Thx in advance
  24. Oliver Hader voted on patch set 10 V +1 CR +1 01/29/18, 22:05

  25. Markus Klein commented on patch set 10 01/29/18, 23:11

    My comments are nitpicks and not important to justify a followup.