55434[TASK] Improved extension configuration API
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Oliver Hader +1
- Susi Moog +1
-
Verified V +2
- Helmut Hummel +2
- Oliver Hader +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php5+491 −20
- typo3/sysext/core/Tests/Unit/Configuration/ExtensionConfigurationTest.php+0 −12
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php4+5 −5
- typo3/sysext/install/Classes/Controller/InstallerController.php+3 −3
- typo3/sysext/install/Classes/Controller/LayoutController.php+3 −3
- typo3/sysext/install/Classes/Service/ExtensionConfigurationService.php+16 −404
- composer.json+2 −2
- composer.lock+7 −8
Review log 2942
Show 1017 earlier messages
-
Christian Kuhn uploaded patch set 1 01/23/18, 12:43
-
TYPO3com voted on patch set 1 V -1 01/23/18, 12:45 Completed build in 02m 01s on Tue, 23 Jan, 01:45 PM Test Summary: 2724 of 2865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18538
-
Christian Kuhn uploaded patch set 2 01/23/18, 13:33
-
TYPO3com voted on patch set 2 V -1 01/23/18, 13:33 Completed build in 11s on Tue, 23 Jan, 02:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18542
-
Christian Kuhn uploaded patch set 3 01/23/18, 13:34
-
TYPO3com voted on patch set 3 V +1 01/23/18, 13:42 Completed build in 08m 02s on Tue, 23 Jan, 02:42 PM Test Summary: 30190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18543
-
Helmut Hummel commented on patch set 3 01/23/18, 14:22
-
Christian Kuhn commented on patch set 3 01/24/18, 08:59
InstallUtility.php:164ReplyDone -
Christian Kuhn uploaded patch set 4 01/24/18, 09:28
-
TYPO3com voted on patch set 4 V -1 01/24/18, 09:37 Completed build in 09m 05s on Wed, 24 Jan, 10:37 AM Test Summary: 1 of 30414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18567
-
TYPO3com commented on patch set 4 01/24/18, 10:20 Completed build in 1h 00m 57s on Wed, 24 Jan, 11:20 AM Test Summary: 1 of 30414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18567
-
Christian Kuhn commented on patch set 3 01/24/18, 10:20
InstallUtility.php:164Replydoes not work, installing ext:introduction fails if moving that call around - reverting to version of patch set 3 with set 5. -
Christian Kuhn uploaded patch set 5 01/24/18, 10:21
-
TYPO3com voted on patch set 5 V +1 01/24/18, 10:28 Completed build in 06m 21s on Wed, 24 Jan, 11:28 AM Test Summary: 30259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18572
-
Alexander Opitz commented on patch set 5 01/29/18, 10:40
ExtensionConfiguration.php:190set()? -
Alexander Opitz commented on patch set 5 V +1 01/29/18, 11:03
Tested with installing and configuring TV+ via ExtensionManager -
TYPO3com commented on patch set 4 01/29/18, 18:14 Completed build in 9h 47m 20s on Mon, 29 Jan, 07:14 PM Test Summary: 1 of 30414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18567
-
Helmut Hummel commented on patch set 3 01/29/18, 18:18
InstallUtility.php:164Replyuhm, why does it fail? I mean the main point of this change is, that this does not happen: https://bamboo.typo3.com/artifact/CORE-GTC/ACINSTPGPHP72/build-18567/Test-Report/typo3temp/var/tests/AcceptanceReportsInstallPgsql/TYPO3.CMS.Core.Tests.AcceptanceInstallPsql.InstallWithPgsqlCest.installTypo3OnPgSql.fail.png So to me it seems that there is something missing here -
Jigal van Hemert commented on patch set 5 01/29/18, 19:11
> (1 comment) The failed logs are for patch set 4. Number 5 already has a +1 from bamboo. -
Jigal van Hemert commented on patch set 5 01/29/18, 19:16
> > (1 comment) > > The failed logs are for patch set 4. Number 5 already has a +1 from > bamboo. Sorry, I go completely confused with the numbering and reverting. Ignore this comment please :-) -
Helmut Hummel commented on patch set 5 V -1 CR -1 01/29/18, 20:11
lookig at it -
Helmut Hummel commented on patch set 5 01/29/18, 20:25
ExtensionConfiguration.php:190ReplyDone -
Helmut Hummel uploaded patch set 6 01/29/18, 20:26
-
Helmut Hummel commented on patch set 6 01/29/18, 20:27
since I could not reproduce any failure with moving saveDefaultConfiguration back to its place, I pushed a new version which contains this change also fixed a typo mentioned by alex -
TYPO3com voted on patch set 6 V -1 01/29/18, 20:32 Completed build in 06m 18s on Mon, 29 Jan, 09:32 PM Test Summary: 1 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18710
-
TYPO3com commented on patch set 6 01/29/18, 21:09 Completed build in 49m 56s on Mon, 29 Jan, 10:09 PM Test Summary: 1 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18710
-
TYPO3com commented on patch set 6 01/29/18, 21:20 Completed build in 1h 44m 02s on Mon, 29 Jan, 10:20 PM Test Summary: 1 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18710
-
Helmut Hummel uploaded patch set 7 01/29/18, 21:23
-
Helmut Hummel uploaded patch set 8 01/29/18, 21:24
-
TYPO3com voted on patch set 7 V +1 01/29/18, 21:32 Completed build in 08m 55s on Mon, 29 Jan, 10:32 PM Test Summary: 30355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18713
-
TYPO3com voted on patch set 8 V -1 01/29/18, 21:33 Completed build in 08m 49s on Mon, 29 Jan, 10:33 PM Test Summary: 3 of 30510 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18714
-
Helmut Hummel uploaded patch set 9 01/29/18, 21:39
-
Helmut Hummel voted on patch set 9 V +2 CR +2 01/29/18, 21:40
-
TYPO3com voted on patch set 9 V +1 01/29/18, 21:47 Completed build in 07m 48s on Mon, 29 Jan, 10:47 PM Test Summary: 30355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18715
-
Susi Moog voted on patch set 9 V +1 CR +1 01/29/18, 21:52
-
Susi Moog merged patch set 10 01/29/18, 21:52
-
Markus Klein commented on patch set 9 01/29/18, 21:58
ExtensionConfiguration.php:45builtExtensionConfiguration.php:58initialize with [] or add null as typehint aboveExtensionConfiguration.php:200can be removed -
Oliver Hader commented on patch set 10 01/29/18, 21:58
I tried to analyze the pgsql issue as well but could not find anything obvious in the code. That also might be a side effect on the testing agents... -
Susi Moog commented on patch set 10 01/29/18, 22:00
> Patch Set 10: > > I tried to analyze the pgsql issue as well but could not find anything obvious in the code. That also might be a side effect on the testing agents... Tested with pgsql locally with and without subfolder installation, both work fine. Discussed with Helmut to have a look at the issue / agents after the release. -
Oliver Hader commented on patch set 10 01/29/18, 22:05
@Susi: Thx @Markus: Could you please create a follow-up if you think these changes are required for the 9.1 release. Thx in advance -
Oliver Hader voted on patch set 10 V +1 CR +1 01/29/18, 22:05
-
Markus Klein commented on patch set 10 01/29/18, 23:11
My comments are nitpicks and not important to justify a followup.
InstallUtility.php:164