Review main Merged

55437[BUGFIX] Show and hide arrow correctly in page tree

Manuel Selbach CR +2 V +2 Easy +1 −1 updated 01/25/18, 10:54

Commit message

This will set the attribute "visibility" to the correct value "visible"
or "hidden" instead of "collapse" so the arrow icon of the page tree
acts accordingly in all browsers.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Andreas Kienast +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1213

  1. Manuel Selbach uploaded patch set 1 01/23/18, 14:23

  2. Andreas Kienast voted on patch set 1 CR +1 01/23/18, 14:25

  3. TYPO3com voted on patch set 1 V +1 01/23/18, 14:31 Completed build in 07m 10s on Tue, 23 Jan, 03:31 PM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18546

  4. Tymoteusz Motylewski commented on patch set 1 01/23/18, 14:31

    SvgTree.js:915

    the collapse and hidden value have different meaning. see https://www.w3.org/TR/SVG11/painting.html#VisibilityProperty If I remember correctly the collapse value was used on purpose here (not sure whether it was because of the spacing or receiving pointer events). changing it to hidden requires intensive testing inside a tree which has several mount points and few levels.
  5. Tymoteusz Motylewski commented on patch set 1 01/23/18, 14:33

    why do you think collapse value is not correct? can you point me to some source?
  6. Manuel Selbach commented on patch set 1 01/23/18, 15:09

    In this definition for the value "collapse" https://www.w3schools.com/jsref/prop_style_visibility.asp you can find, that it is equal to hidden only for table row or cell. As this is not the given here, I suggest to use hidden. Also the value "collapse" gets interpreted differently from browser to browser, "hidden" not.
  7. Tymoteusz Motylewski commented on patch set 1 01/23/18, 15:58

    @Manuel, you're referring to documentation for HTML, while you should refer to SVG docs (see the link I've posted). I'm trying to say that this change is not a no-brainer, it requires a proper testing.
  8. Manuel Selbach commented on patch set 1 01/23/18, 16:32

    @Tymoteusz Sorry, if my answer sounded a bit harsh. I guess you or someone you know tested the tree previously elaborately and ended up with the "collapse". As the bug report shows, the behavior in Safari is a bit different than other browsers and the element is visible. In the documentation you referred it is mentioned, that collapse equals to hidden. My little testing in Firefox, Chrome, Safari, all on on macOS 10.13.2 and IE11 on Win7 results in no problems. Please let me know how to test all relevant scenarios and I will do or could you provide some automatic testing here?
  9. Tymoteusz Motylewski commented on patch set 1 01/23/18, 17:59

    @Manuel, I'm doing exactly that. I'm testing it, checking my notes, and asking other guys to find out what was the reason for this value :)
  10. Manuel Selbach commented on patch set 1 01/24/18, 08:48

    @Tymoteusz Thank you very much for your effort and taking care of this issue
  11. Tymoteusz Motylewski commented on patch set 1 V +1 CR +1 01/25/18, 10:31

    checked the cases which were failing before (which were the reason to switch to collapse), and it still works. Probably fixed in the meantime with css.
  12. Andreas Kienast voted on patch set 1 V +2 CR +2 01/25/18, 10:53

  13. Andreas Kienast merged patch set 2 01/25/18, 10:54