Review TYPO3_8-7 Merged

55444[BUGFIX] Allow dev branch install of subtree split packages

Helmut Hummel CR +2 V +2 Hard +60 −204 updated 02/05/18, 19:24

Commit message

To make it possible to require subtree split packages
as a dev 8.7.*@dev versions, we need to adapt the
dependencies of the packages.

For a release these dependencies will be set to
exact version numbers before tagging.

Branch aliases in the packages can be removed,
as the TYPO3_8-7 branch does not exist in the
splitted repos, but only a 8.7 branch.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Hader +1
    • Jigal van Hemert +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 48

Show 28 more files

Review log 912

  1. Helmut Hummel uploaded patch set 1 01/24/18, 12:03

  2. Helmut Hummel updated the commit message in patch set 2 01/24/18, 12:07

  3. TYPO3com voted on patch set 1 V +1 01/24/18, 12:11 Completed build in 07m 50s on Wed, 24 Jan, 01:11 PM Test Summary: 57881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1678

  4. TYPO3com voted on patch set 2 V -1 01/24/18, 12:17 Completed build in 09m 55s on Wed, 24 Jan, 01:17 PM Test Summary: 1 of 58225 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1679

  5. TYPO3com voted on patch set 2 V +1 01/24/18, 12:20 Completed build in 22m 46s on Wed, 24 Jan, 01:20 PM Test Summary: 57881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1679

  6. Christian Kuhn commented on patch set 2 01/24/18, 12:28

    Thx for that patch helmut. One question is open for me, though: In which way does that change the packaging and what needs to be coordinated here? do you organize that maybe with olly?
  7. Benni Mack commented on patch set 2 01/24/18, 13:26

    I guess like this: The first commit on release, needs to set this to 8.7.10, and the "set dev version blabla" followup commit after the release needs to set it back to 8.7-dev. Maybe Olly could take over this one to integrate into the release process script.
  8. Oliver Hader voted on patch set 2 CR +1 02/05/18, 18:08

  9. Susi Moog voted on patch set 2 CR +1 02/05/18, 18:33

  10. Jigal van Hemert voted on patch set 2 CR +1 02/05/18, 19:03

  11. Benni Mack voted on patch set 2 V +2 CR +2 02/05/18, 19:24

  12. Benni Mack merged patch set 3 02/05/18, 19:24