Review main Merged

55446[TASK] Add feature switch "unifiedPageTranslationHandling"

Benni Mack CR +2 V +2 Normal +95 −6 updated 03/02/18, 10:55

Commit message

The feature switch "unifiedPageTranslationHandling" is active for all new
installations, but not active for existing installations.

It does the following when active:
- All DB schema migrations decide to drop "pages_language_overlay"
- TCA migration no longer throws a deprecation info (but still unsets "pages_language_overlay")

Once the Update Wizard for migrating pages_language_overlay records is done,
the feature is enabled.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Tobi Kretschmann +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1623

  1. Benni Mack uploaded patch set 1 01/24/18, 13:22

  2. TYPO3com voted on patch set 1 V +1 01/24/18, 13:28 Completed build in 06m 18s on Wed, 24 Jan, 02:28 PM Test Summary: 30301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18580

  3. Mathias Schreiber uploaded patch set 2 02/05/18, 19:19

  4. TYPO3com voted on patch set 2 V +1 02/05/18, 19:33 Completed build in 13m 29s on Mon, 5 Feb, 08:33 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18960

  5. Benni Mack updated the commit message in patch set 3 02/07/18, 13:19

  6. TYPO3com voted on patch set 3 V +1 02/07/18, 13:27 Completed build in 07m 54s on Wed, 7 Feb, 02:27 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19074

  7. Benni Mack updated the commit message in patch set 4 02/13/18, 20:42

  8. TYPO3com voted on patch set 4 V +1 02/13/18, 20:51 Completed build in 09m 34s on Tue, 13 Feb, 09:51 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19521

  9. Mathias Schreiber uploaded patch set 5 02/14/18, 21:28

  10. TYPO3com voted on patch set 5 V +1 02/14/18, 21:37 Completed build in 09m 04s on Wed, 14 Feb, 10:37 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19608

  11. Mathias Schreiber uploaded patch set 6 02/14/18, 22:17

  12. Mathias Schreiber commented on patch set 6 V +1 CR +1 02/14/18, 22:18

    tried to be smart... failed ;-)
  13. TYPO3com voted on patch set 6 V +1 02/14/18, 22:26 Completed build in 08m 16s on Wed, 14 Feb, 11:26 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19613

  14. Christian Kuhn commented on patch set 6 02/15/18, 02:12

    seeing the 'hack' in schemaMigrator - what is the plan with that feature? it will be removed in v10 again?

    SchemaMigrator.php:276

    pretty brutal to do that here, but there is probably no different way.

    FactoryConfiguration.php:27

    ah, great you catch this one.
  15. Stefan Neufeind voted on patch set 6 CR +1 02/15/18, 05:45

  16. Benni Mack commented on patch set 6 02/15/18, 10:52

    I think we need a RST for feature switch?
  17. Mathias Schreiber uploaded patch set 7 02/15/18, 11:04

  18. Mathias Schreiber voted on patch set 7 V +1 CR +1 02/15/18, 11:07

  19. TYPO3com voted on patch set 7 V +1 02/15/18, 11:12 Completed build in 08m 13s on Thu, 15 Feb, 12:12 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19636

  20. Tobi Kretschmann voted on patch set 7 CR +1 02/26/18, 11:02

  21. Frank Nägler voted on patch set 7 CR +1 03/02/18, 10:39

  22. Frank Nägler voted on patch set 7 V +2 CR +2 03/02/18, 10:55

  23. Frank Nägler merged patch set 8 03/02/18, 10:55