Review TYPO3_8-7 Merged

55450[BUGFIX] Catch DatabaseRecordException when editing record with deleted relation

Andreas Kienast CR +2 V +2 Normal +66 −4 updated 02/16/18, 10:07

Commit message

Editing a record with a deleted related record leads to an uncaught
DatabaseRecordException. This patch catches the exception and
ignores such records, but logs a warning.

Due to possible errors occurring with certain DBMS (e.g. MySQL
strict) columns may require a default value now in TCA.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Reiner Teubner +1
  • Verified V +2
    • Andreas Wolf +2
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Andreas Kienast uploaded patch set 1 01/24/18, 15:50

  2. Christian Kuhn voted on patch set 1 CR +1 01/24/18, 15:53

  3. Andreas Kienast commented on patch set 1 V -1 01/24/18, 16:00

    Still need to test stuff
  4. TYPO3com voted on patch set 1 V +1 01/24/18, 16:04 Completed build in 14m 18s on Wed, 24 Jan, 05:04 PM Test Summary: 57881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1685

  5. Christian Kuhn voted on patch set 1 CR 0 01/24/18, 16:06

  6. Andreas Kienast uploaded patch set 2 01/24/18, 19:11

  7. TYPO3com voted on patch set 2 V +1 01/24/18, 19:21 Completed build in 10m 01s on Wed, 24 Jan, 08:21 PM Test Summary: 57881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1688

  8. Reiner Teubner voted on patch set 2 V +1 CR +1 01/25/18, 08:54

  9. Andreas Wolf voted on patch set 2 V +2 CR +2 01/27/18, 18:34

  10. Andreas Wolf merged patch set 3 01/27/18, 18:34

  11. Stephan Großberndt commented on patch set 3 02/16/18, 09:59

    I added this (as a cleanly applying patch) on a 7.6.24 instance as I had the same problem there. What do you think, worth a general backport?
  12. Andreas Kienast commented on patch set 3 02/16/18, 10:07

    > Patch Set 3: > > I added this (as a cleanly applying patch) on a 7.6.24 instance as I had the same problem there. What do you think, worth a general backport? If the codebase doesn't differ that much compared to 8.7, I'd consider doing a backport.