Review main Merged

55466[BUGFIX] Only reference existing locallang files

Daniel Goerz CR +2 V +2 Easy +17 −17 updated 01/27/18, 10:20

Commit message

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Joerg Kummer +1
  • Verified V +2
    • Andreas Wolf +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 79

  1. Daniel Goerz uploaded patch set 1 01/26/18, 21:38

  2. TYPO3com voted on patch set 1 V +1 01/26/18, 21:45 Completed build in 06m 22s on Fri, 26 Jan, 10:45 PM Test Summary: 30301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18638

  3. Joerg Kummer commented on patch set 1 CR -1 01/26/18, 23:40

    Looks good, just found one file which we should also change from xml file to xlif format

    tt_content_flexform.xml:10

    This file is still in old xml format, both 8.7 and master
  4. Daniel Goerz commented on patch set 1 01/26/18, 23:51

    tt_content_flexform.xml:10 Reply

    Ah yes, good catch. I did not want to push changes in the test related files with this patch. That one slipped through, will update tomorrow.
  5. Daniel Goerz uploaded patch set 2 01/27/18, 08:24

  6. TYPO3com voted on patch set 2 V +1 01/27/18, 08:30 Completed build in 06m 03s on Sat, 27 Jan, 09:30 AM Test Summary: 30301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18643

  7. Joerg Kummer voted on patch set 2 V +1 CR +1 01/27/18, 08:58

  8. Andreas Wolf voted on patch set 2 V +2 CR +2 01/27/18, 10:20

  9. Andreas Wolf merged patch set 3 01/27/18, 10:20