Review main Merged

55472[BUGFIX] Refactor record querying in deep nested structures in recycler

Andreas Kienast CR +2 V +2 Hard +211 −58 updated 02/20/18, 19:31

Commit message

This patch refactors how the recycler queries records in deep page
structures.
Instead of resolving each level of the page tree on demand and executing
the complex logic of creating query builders and paging all over again,
a list of page ids is generated once and stored in the Caching Framework
for the current request. This list is then used in an multiple `IN()`
statements (depending on the DBMS engine used).

Also, some wrong type hints and a wrong language file reference are
fixed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2536

Show 811 earlier messages
  1. Andreas Kienast uploaded patch set 1 01/27/18, 23:14

  2. TYPO3com voted on patch set 1 V -1 01/27/18, 23:20 Completed build in 06m 39s on Sun, 28 Jan, 12:20 AM Test Summary: 2 of 30513 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18668

  3. Andreas Kienast uploaded patch set 2 01/27/18, 23:27

  4. TYPO3com voted on patch set 2 V +1 01/27/18, 23:34 Completed build in 06m 32s on Sun, 28 Jan, 12:34 AM Test Summary: 30358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18669

  5. Andreas Kienast commented on patch set 2 CR -1 01/27/18, 23:39

    I guess I have an idea why the code was built like it was and why the test failed with PS 1. It seems there was some "grouping" by the pid to reflect the page tree. Will take a look again.
  6. Oliver Klee commented on patch set 2 01/28/18, 00:16

    DeletedRecords.php:512

    The type of some @param are missing, and the parameters of all new methods should have type hinting.
  7. Andreas Kienast uploaded patch set 3 01/28/18, 15:12

  8. TYPO3com voted on patch set 3 V +1 01/28/18, 15:18 Completed build in 05m 54s on Sun, 28 Jan, 04:18 PM Test Summary: 30361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18676

  9. Frank Nägler commented on patch set 2 01/29/18, 13:35

    DeletedRecords.php:267

    why do you add the new parameter not at the end of the signature?
  10. Andreas Kienast commented on patch set 3 01/29/18, 14:05

    DeletedRecords.php:267 Reply

    Gut feeling, I'd say, the method is protected anyway
  11. Andreas Kienast updated the commit message in patch set 4 02/05/18, 19:14

  1. TYPO3com voted on patch set 4 V +1 02/05/18, 19:22 Completed build in 08m 20s on Mon, 5 Feb, 08:22 PM Test Summary: 30419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18959

  2. Mathias Brodala updated the commit message in patch set 5 02/07/18, 09:14

  3. Tymoteusz Motylewski commented on patch set 4 02/07/18, 09:14

    Have you considered the limits in different DBMS? e.g. of number of arguments for IN statements, or number of prepares statement variables.
  4. Tymoteusz Motylewski commented on patch set 4 02/07/18, 09:16

  5. TYPO3com voted on patch set 5 V +1 02/07/18, 09:20 Completed build in 06m 19s on Wed, 7 Feb, 10:20 AM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19064

  6. Andreas Kienast commented on patch set 5 CR -1 02/07/18, 09:36

    Thanks Tymek, you're right. I will take a look again.
  7. Andreas Kienast uploaded patch set 6 02/09/18, 20:19

  8. TYPO3com voted on patch set 6 V +1 02/09/18, 20:38 Completed build in 18m 46s on Fri, 9 Feb, 09:38 PM Test Summary: 30473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19227

  9. Mathias Schreiber updated the commit message in patch set 7 02/09/18, 20:46

  10. Mathias Schreiber voted on patch set 7 V +1 CR +1 02/09/18, 20:46

  11. TYPO3com voted on patch set 7 V +1 02/09/18, 20:56 Completed build in 09m 19s on Fri, 9 Feb, 09:56 PM Test Summary: 30473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19234

  12. Oliver Wand voted on patch set 7 CR +1 02/16/18, 10:07

  13. Andreas Wolf commented on patch set 7 CR -1 02/18/18, 10:19

    DeletedRecords.php:553

    Could we just merge this to one `$id = abs((int)$id);`?

    DeletedRecords.php:558

    This could be simplified with a ternary expression.

    DeletedRecords.php:574

    Isn't this missing a "," at the beginning, like the clause above?
  14. Andreas Kienast commented on patch set 7 02/18/18, 11:43

    DeletedRecords.php:574 Reply

    I don't think so as the the code will get recursed until $begin is 0, where the comma is prepended. But I agree that this is hard to read, we should use an array here, for example.
  15. Andreas Kienast uploaded patch set 8 02/18/18, 11:50

  16. TYPO3com voted on patch set 8 V -1 02/18/18, 11:51 Completed build in 10s on Sun, 18 Feb, 12:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19827

  17. Andreas Kienast uploaded patch set 9 02/18/18, 11:51

  18. TYPO3com voted on patch set 9 V -1 02/18/18, 11:59 Completed build in 07m 45s on Sun, 18 Feb, 12:59 PM Test Summary: 1 of 31057 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19828

  19. TYPO3com voted on patch set 9 V +1 02/18/18, 12:01 Completed build in 17m 14s on Sun, 18 Feb, 01:01 PM Test Summary: 30905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19828

  20. Mathias Schreiber voted on patch set 9 V +1 CR +1 02/18/18, 14:04

  21. Christian Kuhn uploaded patch set 10 02/20/18, 19:18

  22. Mathias Schreiber voted on patch set 10 V +1 CR +1 02/20/18, 19:19

  23. TYPO3com voted on patch set 10 V +1 02/20/18, 19:29 Completed build in 11m 51s on Tue, 20 Feb, 08:30 PM Test Summary: 30905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19946

  24. Christian Kuhn voted on patch set 10 V +2 CR +2 02/20/18, 19:31

  25. Christian Kuhn merged patch set 11 02/20/18, 19:31