Review main Merged

55473[BUGFIX] Forward header in DebugUtility:debug to renderDump

Georg Ringer CR +2 V +2 Easy +5 −5 updated 02/05/18, 19:44

Commit message

Improve the debug output by forwarding the given title.

Review

  • Code review CR +2
    • Benni Mack +2
    • Sascha Rademacher +1
    • Oliver Klee +1
    • Tobi Kretschmann +1
    • Jan Stockfisch +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • Reiner Teubner +1
    • Steffen Frese +1
  • Verified V +2
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1518

  1. Georg Ringer uploaded patch set 1 01/28/18, 11:40

  2. TYPO3com voted on patch set 1 V -1 01/28/18, 11:49 Completed build in 08m 47s on Sun, 28 Jan, 12:49 PM Test Summary: 3 of 30513 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18670

  3. Oliver Klee commented on patch set 1 01/28/18, 11:59

    DebugUtility.php:49

    Can't we use this as the default value in the declaration instead? Or are there cases where the header is explicitly passed as an empty string?
  4. Georg Ringer uploaded patch set 2 01/29/18, 11:40

  5. TYPO3com voted on patch set 2 V -1 01/29/18, 11:46 Completed build in 05m 44s on Mon, 29 Jan, 12:46 PM Test Summary: 3 of 30513 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18695

  6. Georg Ringer uploaded patch set 3 01/30/18, 07:06

  7. TYPO3com voted on patch set 3 V +1 01/30/18, 07:12 Completed build in 05m 30s on Tue, 30 Jan, 08:12 AM Test Summary: 30355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18718

  8. Henning Liebe voted on patch set 3 CR +1 01/30/18, 12:41

  9. Sascha Rademacher voted on patch set 3 CR +1 01/30/18, 12:42

  10. Steffen Frese voted on patch set 3 CR +1 01/30/18, 13:10

  11. Oliver Klee voted on patch set 3 CR +1 01/30/18, 13:49

  12. Reiner Teubner voted on patch set 3 V +1 CR +1 01/31/18, 09:15

  13. Jörg Bösche voted on patch set 3 V +1 CR +1 02/05/18, 08:25

  14. Tobi Kretschmann voted on patch set 3 V +1 CR +1 02/05/18, 09:09

  15. Jan Stockfisch voted on patch set 3 CR +1 02/05/18, 10:04

  16. Benni Mack voted on patch set 3 V +2 CR +2 02/05/18, 19:44

  17. Benni Mack merged patch set 4 02/05/18, 19:44

  18. Benni Mack commented on patch set 4 02/05/18, 19:44

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit bf76efc1ed6e2e46910a44b22ba0110cec9c7d4b