Review main Merged

55474[BUGFIX] Properly check `serialized_executions` to avoid warnings with PHP 7.2

Georg Ringer CR +2 V +2 Easy +1 −1 updated 01/29/18, 11:52

Commit message

To avoid warnings with PHP 7.2, `serialized_executions` must be checked
for being not an empty value.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Oliver Hader +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1217

  1. Georg Ringer uploaded patch set 1 01/28/18, 11:43

  2. TYPO3com voted on patch set 1 V -1 01/28/18, 11:52 Completed build in 08m 41s on Sun, 28 Jan, 12:52 PM Test Summary: 1 of 30513 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18671

  3. Oliver Klee updated the commit message in patch set 2 01/28/18, 12:00

  4. TYPO3com voted on patch set 2 V -1 01/28/18, 12:06 Completed build in 06m 41s on Sun, 28 Jan, 01:06 PM Test Summary: 1 of 30513 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18672

  5. TYPO3com commented on patch set 2 01/28/18, 13:06 Completed build in 1h 12m 42s on Sun, 28 Jan, 02:06 PM Test Summary: 1 of 30513 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18672

  6. Stefan Neufeind commented on patch set 2 01/28/18, 13:18

    couldn't figure out why the acceptance-test fails :-(
  7. Andreas Kienast uploaded patch set 3 01/28/18, 15:48

  8. Andreas Kienast uploaded patch set 4 01/28/18, 15:50

  9. TYPO3com voted on patch set 3 V +1 01/28/18, 15:54 Completed build in 06m 31s on Sun, 28 Jan, 04:54 PM Test Summary: 30358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18677

  10. TYPO3com voted on patch set 4 V +1 01/28/18, 15:58 Completed build in 08m 53s on Sun, 28 Jan, 04:58 PM Test Summary: 30358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18678

  11. Stefan Neufeind voted on patch set 4 CR +1 01/28/18, 16:14

  12. Oliver Klee voted on patch set 4 CR +1 01/28/18, 17:57

  13. Wouter Wolters voted on patch set 4 CR +1 01/28/18, 19:52

  14. Stefan Neufeind voted on patch set 4 V +1 01/29/18, 09:58

  15. Oliver Hader voted on patch set 4 V +2 CR +2 01/29/18, 11:52

  16. Oliver Hader merged patch set 5 01/29/18, 11:52

  17. Oliver Hader commented on patch set 5 01/29/18, 11:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 577e5e012f65929f730c88511faf1ec886c6af87